Skip to content

Commit 995ccc0

Browse files
committed
Merge pull request #4596 from Trinick/tomutrename
core: Rename to_mut and from_mut to cast_to_mut and cast_from_mut
2 parents bca39a7 + 9dc8e96 commit 995ccc0

26 files changed

+64
-63
lines changed

src/compiletest/runtest.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ fn check_expected_errors(expected_errors: ~[errors::expected_error],
273273
procres: procres) {
274274

275275
// true if we found the error in question
276-
let found_flags = vec::to_mut(vec::from_elem(
276+
let found_flags = vec::cast_to_mut(vec::from_elem(
277277
vec::len(expected_errors), false));
278278

279279
if procres.status == 0 {

src/libcore/dvec.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ impl<A> DVec<A> {
145145
#[inline(always)]
146146
fn swap_mut(f: &fn(v: ~[mut A]) -> ~[mut A]) {
147147
do self.swap |v| {
148-
vec::from_mut(f(vec::to_mut(move v)))
148+
vec::cast_from_mut(f(vec::cast_to_mut(move v)))
149149
}
150150
}
151151

src/libcore/os.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ pub fn as_c_charp<T>(s: &str, f: fn(*c_char) -> T) -> T {
8484

8585
pub fn fill_charp_buf(f: fn(*mut c_char, size_t) -> bool)
8686
-> Option<~str> {
87-
let buf = vec::to_mut(vec::from_elem(tmpbuf_sz, 0u8 as c_char));
87+
let buf = vec::cast_to_mut(vec::from_elem(tmpbuf_sz, 0u8 as c_char));
8888
do vec::as_mut_buf(buf) |b, sz| {
8989
if f(b, sz as size_t) unsafe {
9090
Some(str::raw::from_buf(b as *u8))
@@ -111,7 +111,7 @@ pub mod win32 {
111111
let mut res = None;
112112
let mut done = false;
113113
while !done {
114-
let buf = vec::to_mut(vec::from_elem(n as uint, 0u16));
114+
let buf = vec::cast_to_mut(vec::from_elem(n as uint, 0u16));
115115
do vec::as_mut_buf(buf) |b, _sz| {
116116
let k : DWORD = f(b, tmpbuf_sz as DWORD);
117117
if k == (0 as DWORD) {
@@ -1269,7 +1269,7 @@ mod tests {
12691269
};
12701270
assert (ostream as uint != 0u);
12711271
let s = ~"hello";
1272-
let mut buf = vec::to_mut(str::to_bytes(s) + ~[0 as u8]);
1272+
let mut buf = vec::cast_to_mut(str::to_bytes(s) + ~[0 as u8]);
12731273
do vec::as_mut_buf(buf) |b, _len| {
12741274
assert (libc::fwrite(b as *c_void, 1u as size_t,
12751275
(str::len(s) + 1u) as size_t, ostream)

src/libcore/vec.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -209,12 +209,12 @@ pub pure fn build_sized_opt<A>(size: Option<uint>,
209209
}
210210

211211
/// Produces a mut vector from an immutable vector.
212-
pub pure fn to_mut<T>(v: ~[T]) -> ~[mut T] {
212+
pub pure fn cast_to_mut<T>(v: ~[T]) -> ~[mut T] {
213213
unsafe { ::cast::transmute(v) }
214214
}
215215

216216
/// Produces an immutable vector from a mut vector.
217-
pub pure fn from_mut<T>(v: ~[mut T]) -> ~[T] {
217+
pub pure fn cast_from_mut<T>(v: ~[mut T]) -> ~[T] {
218218
unsafe { ::cast::transmute(v) }
219219
}
220220

@@ -552,7 +552,7 @@ pub fn consume<T>(v: ~[T], f: fn(uint, v: T)) unsafe {
552552
}
553553

554554
pub fn consume_mut<T>(v: ~[mut T], f: fn(uint, v: T)) {
555-
consume(vec::from_mut(v), f)
555+
consume(vec::cast_from_mut(v), f)
556556
}
557557

558558
/// Remove the last element from a vector and return it
@@ -718,7 +718,7 @@ pub pure fn append_one<T>(lhs: ~[T], x: T) -> ~[T] {
718718

719719
#[inline(always)]
720720
pub pure fn append_mut<T: Copy>(lhs: ~[mut T], rhs: &[const T]) -> ~[mut T] {
721-
to_mut(append(from_mut(lhs), rhs))
721+
cast_to_mut(append(cast_from_mut(lhs), rhs))
722722
}
723723

724724
/**
@@ -3271,22 +3271,22 @@ mod tests {
32713271
}
32723272

32733273
#[test]
3274-
fn to_mut_no_copy() {
3274+
fn cast_to_mut_no_copy() {
32753275
unsafe {
32763276
let x = ~[1, 2, 3];
32773277
let addr = raw::to_ptr(x);
3278-
let x_mut = to_mut(x);
3278+
let x_mut = cast_to_mut(x);
32793279
let addr_mut = raw::to_ptr(x_mut);
32803280
assert addr == addr_mut;
32813281
}
32823282
}
32833283

32843284
#[test]
3285-
fn from_mut_no_copy() {
3285+
fn cast_from_mut_no_copy() {
32863286
unsafe {
32873287
let x = ~[mut 1, 2, 3];
32883288
let addr = raw::to_ptr(x);
3289-
let x_imm = from_mut(x);
3289+
let x_imm = cast_from_mut(x);
32903290
let addr_imm = raw::to_ptr(x_imm);
32913291
assert addr == addr_imm;
32923292
}

src/librustc/middle/liveness.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -661,11 +661,11 @@ fn Liveness(ir: @IrMaps, specials: Specials) -> Liveness {
661661
tcx: ir.tcx,
662662
s: specials,
663663
successors:
664-
vec::to_mut(
664+
vec::cast_to_mut(
665665
vec::from_elem(ir.num_live_nodes,
666666
invalid_node())),
667667
users:
668-
vec::to_mut(
668+
vec::cast_to_mut(
669669
vec::from_elem(ir.num_live_nodes * ir.num_vars,
670670
invalid_users())),
671671
loop_scope: DVec(),

src/librustc/middle/trans/_match.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -985,7 +985,7 @@ fn pick_col(m: &[@Match]) -> uint {
985985
_ => 0u
986986
}
987987
}
988-
let scores = vec::to_mut(vec::from_elem(m[0].pats.len(), 0u));
988+
let scores = vec::cast_to_mut(vec::from_elem(m[0].pats.len(), 0u));
989989
for vec::each(m) |br| {
990990
let mut i = 0u;
991991
for vec::each(br.pats) |p| { scores[i] += score(*p); i += 1u; }

src/librustc/middle/trans/foreign.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -297,14 +297,14 @@ fn classify_ty(ty: TypeRef) -> ~[x86_64_reg_class] {
297297
}
298298

299299
let words = (ty_size(ty) + 7) / 8;
300-
let cls = vec::to_mut(vec::from_elem(words, no_class));
300+
let cls = vec::cast_to_mut(vec::from_elem(words, no_class));
301301
if words > 4 {
302302
all_mem(cls);
303-
return vec::from_mut(move cls);
303+
return vec::cast_from_mut(move cls);
304304
}
305305
classify(ty, cls, 0, 0);
306306
fixup(ty, cls);
307-
return vec::from_mut(move cls);
307+
return vec::cast_from_mut(move cls);
308308
}
309309

310310
fn llreg_ty(cls: &[x86_64_reg_class]) -> TypeRef {

src/librustc/middle/trans/type_use.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ fn type_uses_for(ccx: @crate_ctxt, fn_id: def_id, n_tps: uint)
6868
// Conservatively assume full use for recursive loops
6969
ccx.type_use_cache.insert(fn_id, vec::from_elem(n_tps, 3u));
7070

71-
let cx = {ccx: ccx, uses: vec::to_mut(vec::from_elem(n_tps, 0u))};
71+
let cx = {ccx: ccx, uses: vec::cast_to_mut(vec::from_elem(n_tps, 0u))};
7272
match ty::get(ty::lookup_item_type(cx.ccx.tcx, fn_id).ty).sty {
7373
ty::ty_fn(ref fn_ty) => {
7474
for vec::each(fn_ty.sig.inputs) |arg| {
@@ -84,7 +84,7 @@ fn type_uses_for(ccx: @crate_ctxt, fn_id: def_id, n_tps: uint)
8484
}
8585

8686
if fn_id_loc.crate != local_crate {
87-
let uses = vec::from_mut(copy cx.uses);
87+
let uses = vec::cast_from_mut(copy cx.uses);
8888
ccx.type_use_cache.insert(fn_id, copy uses);
8989
return uses;
9090
}
@@ -167,7 +167,7 @@ fn type_uses_for(ccx: @crate_ctxt, fn_id: def_id, n_tps: uint)
167167
ccx.tcx.sess.parse_sess.interner)));
168168
}
169169
}
170-
let uses = vec::from_mut(copy cx.uses);
170+
let uses = vec::cast_from_mut(copy cx.uses);
171171
// XXX: Bad copy, use @vec instead?
172172
ccx.type_use_cache.insert(fn_id, copy uses);
173173
uses

src/librustc/middle/typeck/check/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3024,7 +3024,7 @@ fn check_bounds_are_used(ccx: @crate_ctxt,
30243024

30253025
// make a vector of booleans initially false, set to true when used
30263026
if tps.len() == 0u { return; }
3027-
let tps_used = vec::to_mut(vec::from_elem(tps.len(), false));
3027+
let tps_used = vec::cast_to_mut(vec::from_elem(tps.len(), false));
30283028

30293029
ty::walk_regions_and_ty(
30303030
ccx.tcx, ty,

src/libstd/bitv.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use core::ops;
1414
use core::prelude::*;
1515
use core::uint;
16-
use core::vec::{to_mut, from_elem};
16+
use core::vec::{cast_to_mut, from_elem};
1717
use core::vec;
1818

1919
struct SmallBitv {
@@ -231,7 +231,7 @@ pub fn Bitv (nbits: uint, init: bool) -> Bitv {
231231
let nelems = nbits/uint_bits +
232232
if nbits % uint_bits == 0 {0} else {1};
233233
let elem = if init {!0} else {0};
234-
let s = to_mut(from_elem(nelems, elem));
234+
let s = cast_to_mut(from_elem(nelems, elem));
235235
Big(~BigBitv(move s))
236236
};
237237
Bitv {rep: move rep, nbits: nbits}
@@ -516,7 +516,7 @@ impl Bitv: Clone {
516516
Bitv{nbits: self.nbits, rep: Small(~SmallBitv{bits: b.bits})}
517517
}
518518
Big(ref b) => {
519-
let st = to_mut(from_elem(self.nbits / uint_bits + 1, 0));
519+
let st = cast_to_mut(from_elem(self.nbits / uint_bits + 1, 0));
520520
let len = st.len();
521521
for uint::range(0, len) |i| { st[i] = b.storage[i]; };
522522
Bitv{nbits: self.nbits, rep: Big(~BigBitv{storage: move st})}

src/libstd/getopts.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ pub type Result = result::Result<Matches, Fail_>;
222222
pub fn getopts(args: &[~str], opts: &[Opt]) -> Result unsafe {
223223
let n_opts = opts.len();
224224
fn f(_x: uint) -> ~[Optval] { return ~[]; }
225-
let vals = vec::to_mut(vec::from_fn(n_opts, f));
225+
let vals = vec::cast_to_mut(vec::from_fn(n_opts, f));
226226
let mut free: ~[~str] = ~[];
227227
let l = args.len();
228228
let mut i = 0;
@@ -337,7 +337,7 @@ pub fn getopts(args: &[~str], opts: &[Opt]) -> Result unsafe {
337337
i += 1;
338338
}
339339
return Ok(Matches {opts: vec::from_slice(opts),
340-
vals: vec::from_mut(move vals),
340+
vals: vec::cast_from_mut(move vals),
341341
free: free});
342342
}
343343

src/libstd/map.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ pub mod chained {
450450
}
451451

452452
fn chains<K,V>(nchains: uint) -> ~[mut Option<@Entry<K,V>>] {
453-
vec::to_mut(vec::from_elem(nchains, None))
453+
vec::cast_to_mut(vec::from_elem(nchains, None))
454454
}
455455

456456
pub fn mk<K:Eq IterBytes Hash, V: Copy>() -> T<K,V> {

src/libstd/md4.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ pub pure fn md4(msg: &[u8]) -> {a: u32, b: u32, c: u32, d: u32} {
4747

4848
let mut i = 0u;
4949
let e = vec::len(msg);
50-
let x = vec::to_mut(vec::from_elem(16u, 0u32));
50+
let x = vec::cast_to_mut(vec::from_elem(16u, 0u32));
5151
while i < e {
5252
let aa = a, bb = b, cc = c, dd = d;
5353

src/libstd/rope.rs

+5-4
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ pub fn concat(v: ~[Rope]) -> Rope {
176176
//Copy `v` into a mut vector
177177
let mut len = vec::len(v);
178178
if len == 0u { return node::Empty; }
179-
let ropes = vec::to_mut(vec::from_elem(len, v[0]));
179+
let ropes = vec::cast_to_mut(vec::from_elem(len, v[0]));
180180
for uint::range(1u, len) |i| {
181181
ropes[i] = v[i];
182182
}
@@ -720,7 +720,7 @@ pub mod node {
720720
//Firstly, split `str` in slices of hint_max_leaf_char_len
721721
let mut leaves = uint::div_ceil(char_len, hint_max_leaf_char_len);
722722
//Number of leaves
723-
let nodes = vec::to_mut(vec::from_elem(leaves, candidate));
723+
let nodes = vec::cast_to_mut(vec::from_elem(leaves, candidate));
724724

725725
let mut i = 0u;
726726
let mut offset = byte_start;
@@ -832,7 +832,7 @@ pub mod node {
832832
}
833833

834834
pub fn serialize_node(node: @Node) -> ~str unsafe {
835-
let mut buf = vec::to_mut(vec::from_elem(byte_len(node), 0u8));
835+
let mut buf = vec::cast_to_mut(vec::from_elem(byte_len(node), 0u8));
836836
let mut offset = 0u;//Current position in the buffer
837837
let it = leaf_iterator::start(node);
838838
loop {
@@ -1158,7 +1158,8 @@ pub mod node {
11581158
}
11591159

11601160
pub fn start(node: @Node) -> T {
1161-
let stack = vec::to_mut(vec::from_elem(height(node)+1u, node));
1161+
let stack = vec::cast_to_mut(
1162+
vec::from_elem(height(node)+1u, node));
11621163
return {
11631164
stack: move stack,
11641165
mut stackpos: 0

src/libstd/sha1.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -259,13 +259,13 @@ pub fn sha1() -> Sha1 {
259259
}
260260
}
261261
let st = {
262-
h: vec::to_mut(vec::from_elem(digest_buf_len, 0u32)),
262+
h: vec::cast_to_mut(vec::from_elem(digest_buf_len, 0u32)),
263263
mut len_low: 0u32,
264264
mut len_high: 0u32,
265-
msg_block: vec::to_mut(vec::from_elem(msg_block_len, 0u8)),
265+
msg_block: vec::cast_to_mut(vec::from_elem(msg_block_len, 0u8)),
266266
mut msg_block_idx: 0u,
267267
mut computed: false,
268-
work_buf: @vec::to_mut(vec::from_elem(work_buf_len, 0u32))
268+
work_buf: @vec::cast_to_mut(vec::from_elem(work_buf_len, 0u32))
269269
};
270270
let sh = (move st) as Sha1;
271271
sh.reset();

src/libstd/sort.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ impl<T: Copy Ord> MergeState<T> {
457457
base2: uint, len2: uint) {
458458
assert len1 != 0 && len2 != 0 && base1+len1 == base2;
459459

460-
let tmp = vec::to_mut(vec::slice(array, base1, base1+len1));
460+
let tmp = vec::cast_to_mut(vec::slice(array, base1, base1+len1));
461461

462462
let mut c1 = 0;
463463
let mut c2 = base2;
@@ -560,7 +560,7 @@ impl<T: Copy Ord> MergeState<T> {
560560
base2: uint, len2: uint) {
561561
assert len1 != 1 && len2 != 0 && base1 + len1 == base2;
562562
563-
let tmp = vec::to_mut(vec::slice(array, base2, base2+len2));
563+
let tmp = vec::cast_to_mut(vec::slice(array, base2, base2+len2));
564564
565565
let mut c1 = base1 + len1 - 1;
566566
let mut c2 = len2 - 1;
@@ -816,7 +816,7 @@ mod test_qsort {
816816

817817
do quick_sort(names) |x, y| { int::le(*x, *y) };
818818

819-
let immut_names = vec::from_mut(move names);
819+
let immut_names = vec::cast_from_mut(move names);
820820

821821
let pairs = vec::zip_slice(expected, immut_names);
822822
for vec::each(pairs) |p| {
@@ -1025,7 +1025,7 @@ mod big_tests {
10251025
let res = do vec::from_fn(num) |i| {
10261026
arr[i % size]
10271027
};
1028-
vec::to_mut(move res)
1028+
vec::cast_to_mut(move res)
10291029
}
10301030

10311031
fn makeRange(n: uint) -> ~[uint] {
@@ -1051,7 +1051,7 @@ mod big_tests {
10511051
let arr = do vec::from_fn(n) |_i| {
10521052
rng.gen_float()
10531053
};
1054-
let arr = vec::to_mut(move arr);
1054+
let arr = vec::cast_to_mut(move arr);
10551055

10561056
tim_sort(arr); // *sort
10571057
isSorted(arr);
@@ -1123,7 +1123,7 @@ mod big_tests {
11231123
let arr = do vec::from_fn(n) |_i| {
11241124
@rng.gen_float()
11251125
};
1126-
let arr = vec::to_mut(move arr);
1126+
let arr = vec::cast_to_mut(move arr);
11271127

11281128
tim_sort(arr); // *sort
11291129
isSorted(arr);

src/libstd/sync.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ fn new_sem_and_signal(count: int, num_condvars: uint)
9797
for num_condvars.times {
9898
queues.push(new_waitqueue());
9999
}
100-
new_sem(count, vec::to_mut(move queues))
100+
new_sem(count, vec::cast_to_mut(move queues))
101101
}
102102

103103
#[doc(hidden)]

src/libsyntax/attr.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,9 @@ fn sort_meta_items(+items: ~[@ast::meta_item]) -> ~[@ast::meta_item] {
304304
}
305305

306306
// This is sort of stupid here, converting to a vec of mutables and back
307-
let v: ~[mut @ast::meta_item] = vec::to_mut(items);
307+
let v: ~[mut @ast::meta_item] = vec::cast_to_mut(items);
308308
std::sort::quick_sort(v, lteq);
309-
vec::from_mut(move v)
309+
vec::cast_from_mut(move v)
310310
}
311311

312312
fn remove_meta_items_by_name(items: ~[@ast::meta_item], name: ~str) ->

src/libsyntax/print/pp.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ fn mk_printer(out: io::Writer, linewidth: uint) -> printer {
142142
// fall behind.
143143
let n: uint = 3 * linewidth;
144144
debug!("mk_printer %u", linewidth);
145-
let token: ~[mut token] = vec::to_mut(vec::from_elem(n, EOF));
146-
let size: ~[mut int] = vec::to_mut(vec::from_elem(n, 0));
147-
let scan_stack: ~[mut uint] = vec::to_mut(vec::from_elem(n, 0u));
145+
let token: ~[mut token] = vec::cast_to_mut(vec::from_elem(n, EOF));
146+
let size: ~[mut int] = vec::cast_to_mut(vec::from_elem(n, 0));
147+
let scan_stack: ~[mut uint] = vec::cast_to_mut(vec::from_elem(n, 0u));
148148
printer_(@{out: out,
149149
buf_len: n,
150150
mut margin: linewidth as int,

0 commit comments

Comments
 (0)