Skip to content

Commit 694f76d

Browse files
committed
syntax: More consistent wording for some literal parsing errors
1 parent fcc2f92 commit 694f76d

14 files changed

+20
-20
lines changed

src/libsyntax/parse/literal.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ impl LitError {
4242
.help("valid widths are 8, 16, 32, 64 and 128")
4343
.emit();
4444
} else {
45-
let msg = format!("invalid suffix `{}` for numeric literal", suf);
45+
let msg = format!("invalid suffix `{}` for integer literal", suf);
4646
diag.struct_span_err(span, &msg)
4747
.span_label(span, format!("invalid suffix `{}`", suf))
4848
.help("the suffix must be one of the integral types (`u32`, `isize`, etc)")
@@ -71,7 +71,7 @@ impl LitError {
7171
.emit();
7272
}
7373
LitError::IntTooLarge => {
74-
diag.struct_span_err(span, "int literal is too large")
74+
diag.struct_span_err(span, "integer literal is too large")
7575
.emit();
7676
}
7777
}

src/test/ui/old-suffixes-are-really-forbidden.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
error: invalid suffix `is` for numeric literal
1+
error: invalid suffix `is` for integer literal
22
--> $DIR/old-suffixes-are-really-forbidden.rs:2:13
33
|
44
LL | let a = 1_is;
55
| ^^^^ invalid suffix `is`
66
|
77
= help: the suffix must be one of the integral types (`u32`, `isize`, etc)
88

9-
error: invalid suffix `us` for numeric literal
9+
error: invalid suffix `us` for integer literal
1010
--> $DIR/old-suffixes-are-really-forbidden.rs:3:13
1111
|
1212
LL | let b = 2_us;

src/test/ui/parser/bad-lit-suffixes.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ fn main() {
2222
1234f1024; //~ ERROR invalid width `1024` for float literal
2323
1234.5f1024; //~ ERROR invalid width `1024` for float literal
2424

25-
1234suffix; //~ ERROR invalid suffix `suffix` for numeric literal
26-
0b101suffix; //~ ERROR invalid suffix `suffix` for numeric literal
25+
1234suffix; //~ ERROR invalid suffix `suffix` for integer literal
26+
0b101suffix; //~ ERROR invalid suffix `suffix` for integer literal
2727
1.0suffix; //~ ERROR invalid suffix `suffix` for float literal
2828
1.0e10suffix; //~ ERROR invalid suffix `suffix` for float literal
2929
}

src/test/ui/parser/bad-lit-suffixes.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ LL | 1234.5f1024;
7878
|
7979
= help: valid widths are 32 and 64
8080

81-
error: invalid suffix `suffix` for numeric literal
81+
error: invalid suffix `suffix` for integer literal
8282
--> $DIR/bad-lit-suffixes.rs:25:5
8383
|
8484
LL | 1234suffix;
8585
| ^^^^^^^^^^ invalid suffix `suffix`
8686
|
8787
= help: the suffix must be one of the integral types (`u32`, `isize`, etc)
8888

89-
error: invalid suffix `suffix` for numeric literal
89+
error: invalid suffix `suffix` for integer literal
9090
--> $DIR/bad-lit-suffixes.rs:26:5
9191
|
9292
LL | 0b101suffix;

src/test/ui/parser/int-literal-too-large-span.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
fn main() {
44
9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999
5-
//~^ ERROR int literal is too large
5+
//~^ ERROR integer literal is too large
66
; // the span shouldn't point to this.
77
}

src/test/ui/parser/int-literal-too-large-span.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: int literal is too large
1+
error: integer literal is too large
22
--> $DIR/int-literal-too-large-span.rs:4:5
33
|
44
LL | 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999

src/test/ui/parser/issue-5544-a.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
fn main() {
22
let __isize = 340282366920938463463374607431768211456; // 2^128
3-
//~^ ERROR int literal is too large
3+
//~^ ERROR integer literal is too large
44
}

src/test/ui/parser/issue-5544-a.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: int literal is too large
1+
error: integer literal is too large
22
--> $DIR/issue-5544-a.rs:2:19
33
|
44
LL | let __isize = 340282366920938463463374607431768211456; // 2^128

src/test/ui/parser/issue-5544-b.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
fn main() {
22
let __isize = 0xffff_ffff_ffff_ffff_ffff_ffff_ffff_ffff_ff;
3-
//~^ ERROR int literal is too large
3+
//~^ ERROR integer literal is too large
44
}

src/test/ui/parser/issue-5544-b.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: int literal is too large
1+
error: integer literal is too large
22
--> $DIR/issue-5544-b.rs:2:19
33
|
44
LL | let __isize = 0xffff_ffff_ffff_ffff_ffff_ffff_ffff_ffff_ff;

src/test/ui/parser/lex-bad-numeric-literals.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ fn main() {
1313
0o; //~ ERROR: no valid digits
1414
1e+; //~ ERROR: expected at least one digit in exponent
1515
0x539.0; //~ ERROR: hexadecimal float literal is not supported
16-
9900000000000000000000000000999999999999999999999999999999; //~ ERROR: int literal is too large
17-
9900000000000000000000000000999999999999999999999999999999; //~ ERROR: int literal is too large
16+
9900000000000000000000000000999999999999999999999999999999; //~ ERROR: integer literal is too large
17+
9900000000000000000000000000999999999999999999999999999999; //~ ERROR: integer literal is too large
1818
0x; //~ ERROR: no valid digits
1919
0xu32; //~ ERROR: no valid digits
2020
0ou32; //~ ERROR: no valid digits

src/test/ui/parser/lex-bad-numeric-literals.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,13 @@ error: octal float literal is not supported
112112
LL | 0o2f32;
113113
| ^^^^^^ not supported
114114

115-
error: int literal is too large
115+
error: integer literal is too large
116116
--> $DIR/lex-bad-numeric-literals.rs:16:5
117117
|
118118
LL | 9900000000000000000000000000999999999999999999999999999999;
119119
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
120120

121-
error: int literal is too large
121+
error: integer literal is too large
122122
--> $DIR/lex-bad-numeric-literals.rs:17:5
123123
|
124124
LL | 9900000000000000000000000000999999999999999999999999999999;

src/test/ui/parser/no-binary-float-literal.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ fn main() {
44
0b101.010;
55
//~^ ERROR binary float literal is not supported
66
0b101p4f64;
7-
//~^ ERROR invalid suffix `p4f64` for numeric literal
7+
//~^ ERROR invalid suffix `p4f64` for integer literal
88
}

src/test/ui/parser/no-binary-float-literal.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ error: binary float literal is not supported
1010
LL | 0b101010f64;
1111
| ^^^^^^^^^^^ not supported
1212

13-
error: invalid suffix `p4f64` for numeric literal
13+
error: invalid suffix `p4f64` for integer literal
1414
--> $DIR/no-binary-float-literal.rs:6:5
1515
|
1616
LL | 0b101p4f64;

0 commit comments

Comments
 (0)