Skip to content

Commit 60ff731

Browse files
committed
Add comments why install steps should never fail.
1 parent f698cac commit 60ff731

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/bootstrap/install.rs

+6
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,15 @@ macro_rules! install {
139139

140140
install!((self, builder, _config),
141141
Docs, "src/doc", _config.docs, only_hosts: false, {
142+
// `expect` should be safe, only None when config.docs is false,
143+
// which is guarded in `should_run`
142144
let tarball = builder.ensure(dist::Docs { host: self.target }).expect("missing docs");
143145
install_sh(builder, "docs", self.compiler.stage, Some(self.target), &tarball);
144146
};
145147
Std, "library/std", true, only_hosts: false, {
146148
for target in &builder.targets {
149+
// `expect` should be safe, only None when host != build, but this
150+
// only runs when host == build
147151
let tarball = builder.ensure(dist::Std {
148152
compiler: self.compiler,
149153
target: *target
@@ -217,6 +221,8 @@ install!((self, builder, _config),
217221
}
218222
};
219223
Analysis, "analysis", Self::should_build(_config), only_hosts: false, {
224+
// `expect` should be safe, only None with host != build, but this
225+
// only uses the `build` compiler
220226
let tarball = builder.ensure(dist::Analysis {
221227
// Find the actual compiler (handling the full bootstrap option) which
222228
// produced the save-analysis data because that data isn't copied

0 commit comments

Comments
 (0)