Skip to content

Commit 5db01aa

Browse files
committed
Take build dependencies into account during license checks
The comment says that build dependencies shouldn't matter unless they do some kind of codegen. It is safer to always check it though.
1 parent 2fa18b8 commit 5db01aa

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

src/tools/tidy/src/deps.rs

+1-10
Original file line numberDiff line numberDiff line change
@@ -460,16 +460,7 @@ fn normal_deps_of_r<'a>(
460460
.iter()
461461
.find(|n| &n.id == pkg_id)
462462
.unwrap_or_else(|| panic!("could not find `{}` in resolve", pkg_id));
463-
// Don't care about dev-dependencies.
464-
// Build dependencies *shouldn't* matter unless they do some kind of
465-
// codegen. For now we'll assume they don't.
466-
let deps = node.deps.iter().filter(|node_dep| {
467-
node_dep
468-
.dep_kinds
469-
.iter()
470-
.any(|kind_info| kind_info.kind == cargo_metadata::DependencyKind::Normal)
471-
});
472-
for dep in deps {
463+
for dep in &node.deps {
473464
normal_deps_of_r(resolve, &dep.pkg, result);
474465
}
475466
}

0 commit comments

Comments
 (0)