Suffering from success

Author: ShE3py

src/tools/compiletest/src/runtest.rs

@@ -381,7 +381,7 @@ impl<'test> TestCx<'test> {
         // if a test does not crash, consider it an error
         if proc_res.status.success() || matches!(proc_res.status.code(), Some(1 | 0)) {
             self.fatal(&format!(
-                "test no longer crashes/triggers ICE! Please give it a mearningful name, \
+                "test no longer crashes/triggers ICE! Please give it a meaningful name, \
             add a doc-comment to the start of the test explaining why it exists and \
             move it to tests/ui or wherever you see fit."
             ));

tests/crashes/114456-2.rs

@@ -0,0 +1,40 @@
+//! Issue #114456: `InferCtxt::super_combine_consts` shouldn't canonicalize its `ty::Const` if its
+//! `ParamEnv` isn't canonicalized yet.
+//@ check-pass
+#![feature(adt_const_params, lazy_type_alias)]
+#![allow(incomplete_features)]
+
+mod foo {
+    pub type Matrix = [usize; 1];
+
+    const EMPTY_MATRIX: Matrix = [0; 1];
+
+    pub struct Walk<const REMAINING: Matrix> {}
+
+    impl Walk<EMPTY_MATRIX> {
+        pub const fn new() -> Self {
+            Self {}
+        }
+    }
+}
+
+mod bar {
+    const EMPTY_MATRIX: <Type as Trait>::Matrix = [0; 1];
+
+    pub struct Walk<const REMAINING: <Type as Trait>::Matrix> {}
+
+    impl Walk<EMPTY_MATRIX> {
+        pub const fn new() -> Self {
+            Self {}
+        }
+    }
+
+    pub enum Type {}
+    pub trait Trait { type Matrix; }
+    impl Trait for Type { type Matrix = [usize; 1]; }
+}
+
+fn main() {
+    let _ = foo::Walk::new();
+    let _ = bar::Walk::new();
+}

tests/crashes/114456.rs

@@ -2,9 +2,11 @@
 //! `ParamEnv` isn't canonicalized yet.
 
 #![feature(with_negative_coherence)]
-
-impl<const N: u8> Copy for [(); N] {}
-//~^ only traits defined in the current crate can be implemented for arbitrary types
+trait Trait {}
+impl<const N: u8> Trait for [(); N] {}
+impl<const N: i8> Trait for [(); N] {}
+//~^ conflicting implementations of trait `Trait` for type `[(); _]`
 //~| mismatched types
+//~^^^^ mismatched types
 
 fn main() {}

tests/crashes/119381.rs

@@ -1,21 +1,24 @@
-error[E0117]: only traits defined in the current crate can be implemented for arbitrary types
-  --> $DIR/combine-consts-with-negative-coherence.rs:6:1
+error[E0119]: conflicting implementations of trait `Trait` for type `[(); _]`
+  --> $DIR/combine-consts-with-negative-coherence.rs:7:1
    |
-LL | impl<const N: u8> Copy for [(); N] {}
-   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^-------
-   | |                          |
-   | |                          this is not defined in the current crate because arrays are always foreign
-   | impl doesn't use only types from inside the current crate
+LL | impl<const N: u8> Trait for [(); N] {}
+   | ----------------------------------- first implementation here
+LL | impl<const N: i8> Trait for [(); N] {}
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `[(); _]`
+
+error[E0308]: mismatched types
+  --> $DIR/combine-consts-with-negative-coherence.rs:6:34
    |
-   = note: define and implement a trait or new type instead
+LL | impl<const N: u8> Trait for [(); N] {}
+   |                                  ^ expected `usize`, found `u8`
 
 error[E0308]: mismatched types
-  --> $DIR/combine-consts-with-negative-coherence.rs:6:33
+  --> $DIR/combine-consts-with-negative-coherence.rs:7:34
    |
-LL | impl<const N: u8> Copy for [(); N] {}
-   |                                 ^ expected `usize`, found `u8`
+LL | impl<const N: i8> Trait for [(); N] {}
+   |                                  ^ expected `usize`, found `i8`
 
-error: aborting due to 2 previous errors
+error: aborting due to 3 previous errors
 
-Some errors have detailed explanations: E0117, E0308.
-For more information about an error, try `rustc --explain E0117`.
+Some errors have detailed explanations: E0119, E0308.
+For more information about an error, try `rustc --explain E0119`.