Sort sidebar implementations on foreign types with natord::compare

Author: chenyukang

Cargo.lock

@@ -2368,6 +2368,12 @@ dependencies = [
 name = "miropt-test-tools"
 version = "0.1.0"
 
+[[package]]
+name = "natord"
+version = "1.0.9"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "308d96db8debc727c3fd9744aac51751243420e46edf401010908da7f8d5e57c"
+
 [[package]]
 name = "new_debug_unreachable"
 version = "1.0.6"
@@ -4725,6 +4731,7 @@ dependencies = [
  "indexmap",
  "itertools",
  "minifier",
+ "natord",
  "pulldown-cmark 0.9.6",
  "regex",
  "rinja",

src/librustdoc/Cargo.toml

@@ -25,6 +25,7 @@ tracing = "0.1"
 tracing-tree = "0.3.0"
 threadpool = "1.8.1"
 unicode-segmentation = "1.9"
+natord = "1.0.9"
 
 [dependencies.tracing-subscriber]
 version = "0.3.3"

src/librustdoc/html/render/sidebar.rs

@@ -297,7 +297,7 @@ fn sidebar_trait<'a>(
                 .filter_map(|i| super::extract_for_impl_name(&i.impl_item, cx))
                 .map(|(name, id)| Link::new(id, name)),
         );
-        foreign_impls.sort();
+        foreign_impls.sort_by(|a, b| natord::compare(&a.name, &b.name));
     }
 
     blocks.extend(

tests/rustdoc/sidebar/sidebar-links-to-foreign-impl.rs

@@ -7,10 +7,12 @@
 //@ has - '//h2[@id="foreign-impls"]' 'Implementations on Foreign Types'
 //@ has - '//*[@class="sidebar-elems"]//section//a[@href="#impl-Foo-for-u32"]' 'u32'
 //@ has - '//*[@id="impl-Foo-for-u32"]//h3[@class="code-header"]' 'impl Foo for u32'
+//@ has - '//*[@id="impl-Foo-for-u8"]//h3[@class="code-header"]' 'impl Foo for u8'
 //@ has - "//*[@class=\"sidebar-elems\"]//section//a[@href=\"#impl-Foo-for-%26str\"]" "&'a str"
 //@ has - "//*[@id=\"impl-Foo-for-%26str\"]//h3[@class=\"code-header\"]" "impl<'a> Foo for &'a str"
 pub trait Foo {}
 
 impl Foo for u32 {}
+impl Foo for u8 {}
 
 impl<'a> Foo for &'a str {}