Auto merge of #44893 - spastorino:remove_new_and_index, r=nikomatsakis

Remove new and index methods already implement for Idx

These are the rest of the repeated implementations for new and index methods. Follow up of #44889

Author: bors

src/librustc/dep_graph/graph.rs

@@ -569,28 +569,20 @@ pub(super) struct DepNodeIndexNew {
 }
 
 impl Idx for DepNodeIndexNew {
-    fn new(idx: usize) -> Self {
-        DepNodeIndexNew::new(idx)
+    fn new(v: usize) -> DepNodeIndexNew {
+        assert!((v & 0xFFFF_FFFF) == v);
+        DepNodeIndexNew { index: v as u32 }
     }
+
     fn index(self) -> usize {
-        self.index()
+        self.index as usize
     }
 }
 
 impl DepNodeIndexNew {
-
     const INVALID: DepNodeIndexNew = DepNodeIndexNew {
         index: ::std::u32::MAX,
     };
-
-    fn new(v: usize) -> DepNodeIndexNew {
-        assert!((v & 0xFFFF_FFFF) == v);
-        DepNodeIndexNew { index: v as u32 }
-    }
-
-    fn index(self) -> usize {
-        self.index as usize
-    }
 }
 
 #[derive(Clone, Debug, PartialEq)]

src/librustc/dep_graph/serialized.rs

@@ -19,14 +19,6 @@ use rustc_data_structures::indexed_vec::{IndexVec, Idx};
          RustcEncodable, RustcDecodable)]
 pub struct SerializedDepNodeIndex(pub u32);
 
-impl SerializedDepNodeIndex {
-    #[inline]
-    pub fn new(idx: usize) -> SerializedDepNodeIndex {
-        assert!(idx <= ::std::u32::MAX as usize);
-        SerializedDepNodeIndex(idx as u32)
-    }
-}
-
 impl Idx for SerializedDepNodeIndex {
     #[inline]
     fn new(idx: usize) -> Self {