Skip to content

Commit 2a7c5e0

Browse files
committed
syntax: Remove usage of io_error in tests
1 parent 94f2dfa commit 2a7c5e0

File tree

3 files changed

+17
-16
lines changed

3 files changed

+17
-16
lines changed

src/libsyntax/ext/expand.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -957,14 +957,13 @@ mod test {
957957
use ast_util;
958958
use codemap;
959959
use codemap::Spanned;
960-
use fold;
961960
use fold::*;
962961
use ext::base::{CrateLoader, MacroCrate};
963962
use parse;
964963
use parse::token::{fresh_mark, gensym, intern};
965964
use parse::token;
966965
use util::parser_testing::{string_to_crate, string_to_crate_and_sess};
967-
use util::parser_testing::{string_to_pat, string_to_tts, strs_to_idents};
966+
use util::parser_testing::{string_to_pat, strs_to_idents};
968967
use visit;
969968
use visit::Visitor;
970969

@@ -1253,14 +1252,14 @@ mod test {
12531252
let varref_name = mtwt_resolve(varref.segments[0].identifier);
12541253
let varref_marks = mtwt_marksof(varref.segments[0].identifier.ctxt,
12551254
invalid_name);
1256-
if (!(varref_name==binding_name)){
1255+
if !(varref_name==binding_name) {
12571256
println!("uh oh, should match but doesn't:");
12581257
println!("varref: {:?}",varref);
12591258
println!("binding: {:?}", bindings[binding_idx]);
12601259
ast_util::display_sctable(get_sctable());
12611260
}
12621261
assert_eq!(varref_name,binding_name);
1263-
if (bound_ident_check) {
1262+
if bound_ident_check {
12641263
// we're checking bound-identifier=?, and the marks
12651264
// should be the same, too:
12661265
assert_eq!(varref_marks,binding_marks.clone());
@@ -1269,7 +1268,7 @@ mod test {
12691268
let fail = (varref.segments.len() == 1)
12701269
&& (mtwt_resolve(varref.segments[0].identifier) == binding_name);
12711270
// temp debugging:
1272-
if (fail) {
1271+
if fail {
12731272
println!("failure on test {}",test_idx);
12741273
println!("text of test case: \"{}\"", teststr);
12751274
println!("");

src/libsyntax/fold.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -861,15 +861,17 @@ pub fn noop_fold_stmt<T: Folder>(s: &Stmt, folder: &mut T) -> SmallVector<@Stmt>
861861

862862
#[cfg(test)]
863863
mod test {
864+
use std::io;
864865
use ast;
865866
use util::parser_testing::{string_to_crate, matches_codepattern};
866867
use parse::token;
867868
use print::pprust;
868869
use super::*;
869870

870871
// this version doesn't care about getting comments or docstrings in.
871-
fn fake_print_crate(s: &mut pprust::State, crate: &ast::Crate) {
872-
pprust::print_mod(s, &crate.module, crate.attrs);
872+
fn fake_print_crate(s: &mut pprust::State,
873+
crate: &ast::Crate) -> io::IoResult<()> {
874+
pprust::print_mod(s, &crate.module, crate.attrs)
873875
}
874876

875877
// change every identifier to "zz"

src/libsyntax/util/parser_testing.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,30 +101,30 @@ pub fn matches_codepattern(a : &str, b : &str) -> bool {
101101
let mut idx_a = 0;
102102
let mut idx_b = 0;
103103
loop {
104-
if (idx_a == a.len() && idx_b == b.len()) {
104+
if idx_a == a.len() && idx_b == b.len() {
105105
return true;
106106
}
107-
else if (idx_a == a.len()) {return false;}
108-
else if (idx_b == b.len()) {
107+
else if idx_a == a.len() {return false;}
108+
else if idx_b == b.len() {
109109
// maybe the stuff left in a is all ws?
110-
if (is_whitespace(a.char_at(idx_a))) {
111-
return (scan_for_non_ws_or_end(a,idx_a) == a.len());
110+
if is_whitespace(a.char_at(idx_a)) {
111+
return scan_for_non_ws_or_end(a,idx_a) == a.len();
112112
} else {
113113
return false;
114114
}
115115
}
116116
// ws in both given and pattern:
117-
else if (is_whitespace(a.char_at(idx_a))
118-
&& is_whitespace(b.char_at(idx_b))) {
117+
else if is_whitespace(a.char_at(idx_a))
118+
&& is_whitespace(b.char_at(idx_b)) {
119119
idx_a = scan_for_non_ws_or_end(a,idx_a);
120120
idx_b = scan_for_non_ws_or_end(b,idx_b);
121121
}
122122
// ws in given only:
123-
else if (is_whitespace(a.char_at(idx_a))) {
123+
else if is_whitespace(a.char_at(idx_a)) {
124124
idx_a = scan_for_non_ws_or_end(a,idx_a);
125125
}
126126
// *don't* silently eat ws in expected only.
127-
else if (a.char_at(idx_a) == b.char_at(idx_b)) {
127+
else if a.char_at(idx_a) == b.char_at(idx_b) {
128128
idx_a += 1;
129129
idx_b += 1;
130130
}

0 commit comments

Comments
 (0)