Skip to content

Commit 273c9b6

Browse files
ywxtywxt
committed
Add FIXMEs for those ignored tests.
1 parent 5eed362 commit 273c9b6

File tree

6 files changed

+27
-0
lines changed

6 files changed

+27
-0
lines changed

‎compiler/rustc_thread_pool/src/broadcast/tests.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ fn spawn_broadcast_self() {
6464
assert!(v.into_iter().eq(0..7));
6565
}
6666

67+
// FIXME: We should fix or remove this ignored test.
6768
#[test]
6869
#[ignore]
6970
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -99,6 +100,7 @@ fn spawn_broadcast_mutual() {
99100
assert_eq!(rx.into_iter().count(), 3 * 7);
100101
}
101102

103+
// FIXME: We should fix or remove this ignored test.
102104
#[test]
103105
#[ignore]
104106
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]

‎compiler/rustc_thread_pool/src/join/tests.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ fn join_context_both() {
9696
assert!(b_migrated);
9797
}
9898

99+
// FIXME: We should fix or remove this ignored test.
99100
#[test]
100101
#[ignore]
101102
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]

‎compiler/rustc_thread_pool/src/scope/tests.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ macro_rules! test_order {
289289
}};
290290
}
291291

292+
// FIXME: We should fix or remove this ignored test.
292293
#[test]
293294
#[ignore]
294295
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -299,6 +300,7 @@ fn lifo_order() {
299300
assert_eq!(vec, expected);
300301
}
301302

303+
// FIXME: We should fix or remove this ignored test.
302304
#[test]
303305
#[ignore]
304306
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -335,6 +337,7 @@ macro_rules! test_nested_order {
335337
}};
336338
}
337339

340+
// FIXME: We should fix or remove this ignored test.
338341
#[test]
339342
#[ignore]
340343
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -345,6 +348,7 @@ fn nested_lifo_order() {
345348
assert_eq!(vec, expected);
346349
}
347350

351+
// FIXME: We should fix or remove this ignored test.
348352
#[test]
349353
#[ignore]
350354
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -355,6 +359,7 @@ fn nested_fifo_order() {
355359
assert_eq!(vec, expected);
356360
}
357361

362+
// FIXME: We should fix or remove this ignored test.
358363
#[test]
359364
#[ignore]
360365
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -365,6 +370,7 @@ fn nested_lifo_fifo_order() {
365370
assert_eq!(vec, expected);
366371
}
367372

373+
// FIXME: We should fix or remove this ignored test.
368374
#[test]
369375
#[ignore]
370376
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -407,6 +413,7 @@ macro_rules! test_mixed_order {
407413
}};
408414
}
409415

416+
// FIXME: We should fix or remove this ignored test.
410417
#[test]
411418
#[ignore]
412419
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -418,6 +425,7 @@ fn mixed_lifo_order() {
418425
assert_eq!(vec, expected);
419426
}
420427

428+
// FIXME: We should fix or remove this ignored test.
421429
#[test]
422430
#[ignore]
423431
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -427,6 +435,7 @@ fn mixed_fifo_order() {
427435
assert_eq!(vec, expected);
428436
}
429437

438+
// FIXME: We should fix or remove this ignored test.
430439
#[test]
431440
#[ignore]
432441
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -438,6 +447,7 @@ fn mixed_lifo_fifo_order() {
438447
assert_eq!(vec, expected);
439448
}
440449

450+
// FIXME: We should fix or remove this ignored test.
441451
#[test]
442452
#[ignore]
443453
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -553,6 +563,7 @@ fn scope_fifo_spawn_broadcast() {
553563
assert_eq!(sum.into_inner(), n * (n - 1) / 2);
554564
}
555565

566+
// FIXME: We should fix or remove this ignored test.
556567
#[test]
557568
#[ignore]
558569
fn scope_spawn_broadcast_nested() {

‎compiler/rustc_thread_pool/src/spawn/tests.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ macro_rules! test_order {
166166
}};
167167
}
168168

169+
// FIXME: We should fix or remove this ignored test.
169170
#[test]
170171
#[ignore]
171172
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -176,6 +177,7 @@ fn lifo_order() {
176177
assert_eq!(vec, expected);
177178
}
178179

180+
// FIXME: We should fix or remove this ignored test.
179181
#[test]
180182
#[ignore]
181183
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -186,6 +188,7 @@ fn fifo_order() {
186188
assert_eq!(vec, expected);
187189
}
188190

191+
// FIXME: We should fix or remove this ignored test.
189192
#[test]
190193
#[ignore]
191194
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -196,6 +199,7 @@ fn lifo_fifo_order() {
196199
assert_eq!(vec, expected);
197200
}
198201

202+
// FIXME: We should fix or remove this ignored test.
199203
#[test]
200204
#[ignore]
201205
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -233,6 +237,7 @@ macro_rules! test_mixed_order {
233237
}};
234238
}
235239

240+
// FIXME: We should fix or remove this ignored test.
236241
#[test]
237242
#[ignore]
238243
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -242,6 +247,7 @@ fn mixed_lifo_fifo_order() {
242247
assert_eq!(vec, expected);
243248
}
244249

250+
// FIXME: We should fix or remove this ignored test.
245251
#[test]
246252
#[ignore]
247253
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]

‎compiler/rustc_thread_pool/src/thread_pool/tests.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ fn self_install() {
151151
assert!(pool.install(|| pool.install(|| true)));
152152
}
153153

154+
// FIXME: We should fix or remove this ignored test.
154155
#[test]
155156
#[ignore]
156157
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -172,6 +173,7 @@ fn mutual_install() {
172173
assert!(ok);
173174
}
174175

176+
// FIXME: We should fix or remove this ignored test.
175177
#[test]
176178
#[ignore]
177179
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -228,6 +230,7 @@ macro_rules! test_scope_order {
228230
}};
229231
}
230232

233+
// FIXME: We should fix or remove this ignored test.
231234
#[test]
232235
#[ignore]
233236
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -237,6 +240,7 @@ fn scope_lifo_order() {
237240
assert_eq!(vec, expected);
238241
}
239242

243+
// FIXME: We should fix or remove this ignored test.
240244
#[test]
241245
#[ignore]
242246
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -279,6 +283,7 @@ fn spawn_fifo_order() {
279283
assert_eq!(vec, expected);
280284
}
281285

286+
// FIXME: We should fix or remove this ignored test.
282287
#[test]
283288
#[ignore]
284289
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]
@@ -316,6 +321,7 @@ fn nested_scopes() {
316321
assert_eq!(counter.into_inner(), pools.len());
317322
}
318323

324+
// FIXME: We should fix or remove this ignored test.
319325
#[test]
320326
#[ignore]
321327
#[cfg_attr(any(target_os = "emscripten", target_family = "wasm"), ignore)]

‎compiler/rustc_thread_pool/tests/stack_overflow_crash.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ fn overflow_code() -> Option<i32> {
3535
ExitStatus::from_raw(0xc00000fd /*STATUS_STACK_OVERFLOW*/).code()
3636
}
3737

38+
// FIXME: We should fix or remove this test on Windows.
3839
#[test]
3940
#[cfg_attr(not(any(unix)), ignore)]
4041
fn stack_overflow_crash() {

0 commit comments

Comments
 (0)