Skip to content

Commit 0b8f6f9

Browse files
committed
Remove duplicated configuration for android
1 parent 6fc5c4a commit 0b8f6f9

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

mk/install.mk

+2-3
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,13 @@ tmp/empty_dir:
5858
# Android runtime setup
5959
# FIXME: This probably belongs somewhere else
6060

61-
# target platform specific variables
62-
# for arm-linux-androidabi
61+
# target platform specific variables for android
6362
define DEF_ADB_DEVICE_STATUS
6463
CFG_ADB_DEVICE_STATUS=$(1)
6564
endef
6665

6766
$(foreach target,$(CFG_TARGET), \
68-
$(if $(or $(findstring $(target),"arm-linux-androideabi"),$(findstring $(target),"aarch64-linux-android")), \
67+
$(if $(findstring android, $(target)), \
6968
$(if $(findstring adb,$(CFG_ADB)), \
7069
$(if $(findstring device,$(shell $(CFG_ADB) devices 2>/dev/null | grep -E '^[_A-Za-z0-9-]+[[:blank:]]+device')), \
7170
$(info install: install-runtime-target for $(target) enabled \

mk/rt.mk

+1-3
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,7 @@ ifeq ($$(CFG_WINDOWSY_$(1)), 1)
139139
JEMALLOC_ARGS_$(1) := --enable-lazy-lock
140140
else ifeq ($(OSTYPE_$(1)), apple-ios)
141141
JEMALLOC_ARGS_$(1) := --disable-tls
142-
else ifeq ($(OSTYPE_$(1)), linux-androideabi)
143-
JEMALLOC_ARGS_$(1) := --disable-tls
144-
else ifeq ($(OSTYPE_$(1)), linux-android)
142+
else ifeq ($(findstring android, $(OSTYPE_$(1))), android)
145143
JEMALLOC_ARGS_$(1) := --disable-tls
146144
endif
147145

mk/tests.mk

+4-5
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,13 @@ endef
107107
$(foreach target,$(CFG_TARGET), \
108108
$(eval $(call DEF_TARGET_COMMANDS,$(target))))
109109

110-
# Target platform specific variables
111-
# for arm-linux-androidabi
110+
# Target platform specific variables for android
112111
define DEF_ADB_DEVICE_STATUS
113112
CFG_ADB_DEVICE_STATUS=$(1)
114113
endef
115114

116115
$(foreach target,$(CFG_TARGET), \
117-
$(if $(or $(findstring $(target),"arm-linux-androideabi"),$(findstring $(target),"aarch64-linux-android")), \
116+
$(if $(findstring android, $(target)), \
118117
$(if $(findstring adb,$(CFG_ADB)), \
119118
$(if $(findstring device,$(shell $(CFG_ADB) devices 2>/dev/null | grep -E '^[:_A-Za-z0-9-]+[[:blank:]]+device')), \
120119
$(info check: android device attached) \
@@ -137,7 +136,7 @@ $(info check: android device test dir $(CFG_ADB_TEST_DIR) ready \
137136
$(shell $(CFG_ADB) shell mkdir $(CFG_ADB_TEST_DIR)) \
138137
$(shell $(CFG_ADB) push $(S)src/etc/adb_run_wrapper.sh $(CFG_ADB_TEST_DIR) 1>/dev/null) \
139138
$(foreach target,$(CFG_TARGET), \
140-
$(if $(or $(findstring $(target),"arm-linux-androideabi"),$(findstring $(target),"aarch64-linux-android")), \
139+
$(if $(findstring android, $(target)), \
141140
$(shell $(CFG_ADB) shell mkdir $(CFG_ADB_TEST_DIR)/$(target)) \
142141
$(foreach crate,$(TARGET_CRATES), \
143142
$(shell $(CFG_ADB) push $(TLIB2_T_$(target)_H_$(CFG_BUILD))/$(call CFG_LIB_GLOB_$(target),$(crate)) \
@@ -463,7 +462,7 @@ $(foreach host,$(CFG_HOST), \
463462
$(foreach crate, $(TEST_CRATES), \
464463
$(if $(findstring $(target),$(CFG_BUILD)), \
465464
$(eval $(call DEF_TEST_CRATE_RULES,$(stage),$(target),$(host),$(crate))), \
466-
$(if $(or $(findstring $(target),"arm-linux-androideabi"), $(findstring $(target),"aarch64-linux-android")), \
465+
$(if $(findstring android, $(target)), \
467466
$(if $(findstring $(CFG_ADB_DEVICE_STATUS),"true"), \
468467
$(eval $(call DEF_TEST_CRATE_RULES_android,$(stage),$(target),$(host),$(crate))), \
469468
$(eval $(call DEF_TEST_CRATE_RULES_null,$(stage),$(target),$(host),$(crate))) \

0 commit comments

Comments
 (0)