Make E0201 detect when duplicate function is a method.

Author: Nick Hamann

src/librustc_typeck/collect.rs

@@ -752,7 +752,11 @@ fn convert_methods<'a,'tcx,'i,I>(ccx: &CrateCtxt<'a, 'tcx>,
     let mut seen_methods = FnvHashSet();
     for (sig, id, ident, vis, span) in methods {
         if !seen_methods.insert(ident.name) {
-            span_err!(tcx.sess, span, E0201, "duplicate associated function");
+            let fn_desc = match sig.explicit_self.node {
+                ast::SelfStatic => "associated function",
+                _               => "method",
+            };
+            span_err!(tcx.sess, span, E0201, "duplicate {}", fn_desc);
         }
 
         convert_method(ccx,

src/librustc_typeck/diagnostics.rs

@@ -901,7 +901,7 @@ trait Baz {
 impl Baz for Foo {
     fn baz(&self) -> bool { true }
 
-    // error: duplicate associated function
+    // error: duplicate method
     fn baz(&self) -> bool { self.0 > 5 }
 }
 ```

src/test/compile-fail/impl-duplicate-methods.rs

@@ -11,7 +11,7 @@
 struct Foo;
 impl Foo {
     fn orange(&self){}
-    fn orange(&self){}   //~ ERROR duplicate associated function
+    fn orange(&self){}   //~ ERROR duplicate method
 }
 
 fn main() {}

src/test/compile-fail/issue-8153.rs

@@ -18,7 +18,7 @@ trait Bar {
 
 impl Bar for Foo {
     fn bar(&self) -> isize {1}
-    fn bar(&self) -> isize {2} //~ ERROR duplicate associated function
+    fn bar(&self) -> isize {2} //~ ERROR duplicate method
 }
 
 fn main() {

src/test/compile-fail/method-macro-backtrace.rs

@@ -29,7 +29,7 @@ impl S {
 
     // Cause an error. It shouldn't have any macro backtrace frames.
     fn bar(&self) { }
-    fn bar(&self) { } //~ ERROR duplicate associated function
+    fn bar(&self) { } //~ ERROR duplicate method
 }
 
 fn main() { }