make the new lint deny-by-default

RalfJung · RalfJung · commit 0073ce329ff0 · 2018-02-21T10:04:41.000+01:00
diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs
@@ -1394,7 +1394,7 @@ pub struct IgnoredGenericBounds;
 
 declare_lint! {
     IGNORED_GENERIC_BOUNDS,
-    Warn,
+    Deny,
     "these generic bounds are ignored"
 }
 
diff --git a/src/test/compile-fail/issue-17994.rs b/src/test/compile-fail/issue-17994.rs
@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+#![warn(ignored_generic_bounds)]
+
 trait Tr {}
 type Huh<T> where T: Tr = isize; //~  ERROR type parameter `T` is unused
                                  //~| WARNING where clauses are ignored in type aliases
diff --git a/src/test/compile-fail/issue-39122.rs b/src/test/compile-fail/issue-39122.rs
@@ -8,6 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-type Foo<T: std::ops::Add> = T; //~ WARNING bounds on generic type parameters are ignored
+type Foo<T: std::ops::Add> = T; //~ ERROR bounds on generic type parameters are ignored
 
-type Bar<T> where T: std::ops::Add = T; //~ WARNING where clauses are ignored
+type Bar<T> where T: std::ops::Add = T; //~ ERROR where clauses are ignored
diff --git a/src/test/compile-fail/private-in-public-warn.rs b/src/test/compile-fail/private-in-public-warn.rs
@@ -14,6 +14,7 @@
 #![feature(associated_type_defaults)]
 #![deny(private_in_public)]
 #![allow(improper_ctypes)]
+#![warn(ignored_generic_bounds)]
 
 mod types {
     struct Priv;
diff --git a/src/test/ui/param-bounds-ignored.rs b/src/test/ui/param-bounds-ignored.rs
@@ -10,6 +10,7 @@
 
 // must-compile-successfully
 #![allow(dead_code, non_camel_case_types)]
+#![warn(ignored_generic_bounds)]
 
 use std::rc::Rc;
 
diff --git a/src/test/ui/param-bounds-ignored.stderr b/src/test/ui/param-bounds-ignored.stderr
@@ -1,92 +1,96 @@
 warning: bounds on generic type parameters are ignored in type aliases
-  --> $DIR/param-bounds-ignored.rs:16:14
+  --> $DIR/param-bounds-ignored.rs:17:14
    |
-16 | type SVec<T: Send+Send> = Vec<T>;
+17 | type SVec<T: Send+Send> = Vec<T>;
    |              ^^^^ ^^^^
    |
-   = note: #[warn(ignored_generic_bounds)] on by default
+note: lint level defined here
+  --> $DIR/param-bounds-ignored.rs:13:9
+   |
+13 | #![warn(ignored_generic_bounds)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^
 
 warning: bounds on generic lifetime parameters are ignored in type aliases
-  --> $DIR/param-bounds-ignored.rs:18:19
+  --> $DIR/param-bounds-ignored.rs:19:19
    |
-18 | type VVec<'b, 'a: 'b+'b> = Vec<&'a i32>;
+19 | type VVec<'b, 'a: 'b+'b> = Vec<&'a i32>;
    |                   ^^ ^^
 
 warning: bounds on generic type parameters are ignored in type aliases
-  --> $DIR/param-bounds-ignored.rs:20:18
+  --> $DIR/param-bounds-ignored.rs:21:18
    |
-20 | type WVec<'b, T: 'b+'b> = Vec<T>;
+21 | type WVec<'b, T: 'b+'b> = Vec<T>;
    |                  ^^ ^^
 
 warning: where clauses are ignored in type aliases
-  --> $DIR/param-bounds-ignored.rs:22:25
+  --> $DIR/param-bounds-ignored.rs:23:25
    |
-22 | type W2Vec<'b, T> where T: 'b, T: 'b = Vec<T>;
+23 | type W2Vec<'b, T> where T: 'b, T: 'b = Vec<T>;
    |                         ^^^^^  ^^^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked function types (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:43:22
+  --> $DIR/param-bounds-ignored.rs:44:22
    |
-43 |     f: for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32)
+44 |     f: for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32)
    |                      ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:51:34
+  --> $DIR/param-bounds-ignored.rs:52:34
    |
-51 | fn bar2<'a, 'b, F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>(
+52 | fn bar2<'a, 'b, F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>(
    |                                  ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:66:28
+  --> $DIR/param-bounds-ignored.rs:67:28
    |
-66 |     where F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32
+67 |     where F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32
    |                            ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:78:25
+  --> $DIR/param-bounds-ignored.rs:79:25
    |
-78 |     where for<'xa, 'xb: 'xa> F: Fn(&'xa i32, &'xb i32) -> &'xa i32
+79 |     where for<'xa, 'xb: 'xa> F: Fn(&'xa i32, &'xb i32) -> &'xa i32
    |                         ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:86:28
+  --> $DIR/param-bounds-ignored.rs:87:28
    |
-86 | struct S1<F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>(F);
+87 | struct S1<F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>(F);
    |                            ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:88:40
+  --> $DIR/param-bounds-ignored.rs:89:40
    |
-88 | struct S2<F>(F) where F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32;
+89 | struct S2<F>(F) where F: for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32;
    |                                        ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:90:37
+  --> $DIR/param-bounds-ignored.rs:91:37
    |
-90 | struct S3<F>(F) where for<'xa, 'xb: 'xa> F: Fn(&'xa i32, &'xb i32) -> &'xa i32;
+91 | struct S3<F>(F) where for<'xa, 'xb: 'xa> F: Fn(&'xa i32, &'xb i32) -> &'xa i32;
    |                                     ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked function types (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:93:29
+  --> $DIR/param-bounds-ignored.rs:94:29
    |
-93 | struct S_fnty(for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32);
+94 | struct S_fnty(for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32);
    |                             ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-  --> $DIR/param-bounds-ignored.rs:96:29
+  --> $DIR/param-bounds-ignored.rs:97:29
    |
-96 | type T1 = Box<for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>;
+97 | type T1 = Box<for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>;
    |                             ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked function types (i.e., `for`)
-   --> $DIR/param-bounds-ignored.rs:100:34
+   --> $DIR/param-bounds-ignored.rs:101:34
     |
-100 |     let _ : Option<for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32> = None;
+101 |     let _ : Option<for<'xa, 'xb: 'xa> fn(&'xa i32, &'xb i32) -> &'xa i32> = None;
     |                                  ^^^
 
 warning: bounds on generic lifetime parameters are ignored in higher-ranked trait bounds (i.e., `for`)
-   --> $DIR/param-bounds-ignored.rs:102:38
+   --> $DIR/param-bounds-ignored.rs:103:38
     |
-102 |     let _ : Option<Box<for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>> = None;
+103 |     let _ : Option<Box<for<'xa, 'xb: 'xa> Fn(&'xa i32, &'xb i32) -> &'xa i32>> = None;
     |                                      ^^^
 

Original file line number	Diff line number	Diff line change
`@@ -1394,7 +1394,7 @@ pub struct IgnoredGenericBounds;`
`1394`	`1394`
`1395`	`1395`	`declare_lint! {`
`1396`	`1396`	`IGNORED_GENERIC_BOUNDS,`
`1397`		`- Warn,`
	`1397`	`+ Deny,`
`1398`	`1398`	`"these generic bounds are ignored"`
`1399`	`1399`	`}`
`1400`	`1400`