Skip to content

Commit ffb8746

Browse files
authored
Merge pull request #697 from jonas-schievink/remove-issue-link
Remove "Open an issue" link
2 parents 1b9a55a + b9f69cd commit ffb8746

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

tests/spec/features/sharing_with_others_spec.rb

-5
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
perma_link = find_link("Permalink to the playground")[:href]
2323
direct_link = find_link("Direct link to the gist")[:href]
2424
urlo_link = find_link("Open a new thread in the Rust user forum")[:href]
25-
issue_link = find_link("Open an issue on the Rust GitHub repository")[:href]
2625

2726
# Navigate away so we can tell that we go back to the same page
2827
visit 'about:blank'
@@ -41,10 +40,6 @@
4140
# Need to be logged in to URLO for this link to work
4241
expect(urlo_link).to match(%r{https://users.rust-lang.org/new-topic})
4342
expect(urlo_link).to match(%{automated%20test})
44-
45-
# Need to be logged in to GitHub for this link to work
46-
expect(issue_link).to match(%r{https://github.com/rust-lang/rust/issues/new})
47-
expect(issue_link).to match(%{automated%20test})
4843
end
4944

5045
def editor

ui/frontend/Output/Gist.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ class Copied extends React.PureComponent<CopiedProps, CopiedState> {
5555
const Links: React.SFC = () => {
5656
const codeUrl = useSelector(selectors.codeUrlSelector);
5757
const gistUrl = useSelector((state: State) => state.output.gist.url);
58-
const issueUrl = useSelector(selectors.issueUrlSelector);
5958
const permalink = useSelector(selectors.permalinkSelector);
6059
const urloUrl = useSelector(selectors.urloUrlSelector);
6160

@@ -65,7 +64,6 @@ const Links: React.SFC = () => {
6564
<Copied href={gistUrl}>Direct link to the gist</Copied>
6665
<Copied href={codeUrl}>Embedded code in link</Copied>
6766
<NewWindow href={urloUrl}>Open a new thread in the Rust user forum</NewWindow>
68-
<NewWindow href={issueUrl}> Open an issue on the Rust GitHub repository</NewWindow>
6967
</Fragment>
7068
);
7169
};

ui/frontend/selectors/index.ts

-9
Original file line numberDiff line numberDiff line change
@@ -237,15 +237,6 @@ export const urloUrlSelector = createSelector(
237237
},
238238
);
239239

240-
export const issueUrlSelector = createSelector(
241-
snippetSelector,
242-
snippet => {
243-
const newIssueUrl = url.parse('https://github.com/rust-lang/rust/issues/new', true);
244-
newIssueUrl.query = { body: snippet };
245-
return url.format(newIssueUrl);
246-
},
247-
);
248-
249240
export const codeUrlSelector = createSelector(
250241
baseUrlSelector, urlQuerySelector, gistSelector,
251242
(baseUrl, query, gist) => {

0 commit comments

Comments
 (0)