Skip to content

Messages of test fail from bors will be doubled. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennytm opened this issue Apr 4, 2018 · 3 comments
Closed

Messages of test fail from bors will be doubled. #1

kennytm opened this issue Apr 4, 2018 · 3 comments

Comments

@kennytm
Copy link
Member

kennytm commented Apr 4, 2018

Example: rust-lang/rust#49642 (comment)

There are 2 identical comments.

cc @TimNN

@TimNN
Copy link
Contributor

TimNN commented Jul 18, 2018

So the issue here is that

(1): Travis posts the status to the merge-commit, which we pick up
(2): Bors posts the same status to the PR-commit, which we also pick up

I'll see if there is an easy way to ignore bors, if not I'll some kind of RLU cache and have the bot remember which builds it has already commented on (probably memory only, so that would be lost if the bot was ever restarted, but given that it's been running for without restart for ~3 months now, I don't think that is going to be an issue).

cc @RalfJung, since you recently asked about this issue.

@kennytm
Copy link
Member Author

kennytm commented Jul 18, 2018

You should be able to distinguish between Travis and Bors by the context. The context used by Bors is currently homu, and those by Travis starts with continuous-integration/travis-ci/

@TimNN
Copy link
Contributor

TimNN commented Jul 18, 2018

@kennytm: Thanks a lot! I hadn't even noticed that field, since it only occurs in the example and is not documented. (I was looking at sender just now, but that seems to be something else).

@TimNN TimNN closed this as completed in 659d2f4 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants