-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(lines_filter_map_ok): move to under methods/
#15925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f1d918e to
701a1ae
Compare
|
Can you make the first commit strictly a file rename. It helps significantly with merge conflicts. |
WARNING: this commit won't compile
701a1ae to
81d2300
Compare
|
Done. I was hesitant to have a broken intermittent commit, but the diff does come out a bit nicer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
It's generally preferred if they pass tests, but that's not a hard rule and nothing actually breaks ( |
changelog: none