Forbid Not operator (!)

[Nugine]

What it does

Forbid the usage of not operator (!) in if $expr, while $expr and assert!($expr).
Use .not() instead. (std::ops::Not)

Lint Name

not_operator_used

Category

style
restriction

Advantage

.not() is more conspicuous than ! and looks continuous.

Drawbacks

No response

Example

assert!(!expr);

if !expr {
   // ...
}

while !expr {
   // ...
}

Could be written as:

use std::ops::Not;

assert!(expr.not());

if expr.not() {
   // ...
}

while expr.not() {
   // ...
}

[Serial-ATA]

This should definitely be in the restriction category

[xFrednet]

This sounds like a specialization of #6286, I would like to have one lint for all operators which is configurable. Then we could also have it in the pedantic group. But the implementation will be a bit more work 😅 🙃