Recommend contains() for find().is_some()

[pickfire]

What it does

Recommend .contains() if find().is_some() is used on a &str (including String) and slice.

Categories (optional)

• Kind: complexity

What is the advantage of the recommended code over the original code

For example:

• Improve readibility

Drawbacks

None.

Example

"hello world".find("world").is_some();

Could be written as:

"hello world".contains("world");

[longlb]

I'd like to tackle this one.

[longlb]

@pickfire How would you call find().is_some() against a slice? Would it be something like slice.iter().find().is_some() or another way, because there is a currently a lint for the iter case that recommends any() be used in its place.

[pickfire]

What you said is correct but later when array comes out to have find we need to add it too.

[rsulli55]

I am interested on working on this, if @longlb has moved on. I have a good start and should be able to submit a pull request tomorrow.

[longlb]

Go for it, I'd actually love to see how you did it because I've been unable to figure out a lot of the compiler stuff.

[rsulli55]

Ok, great!

@pickfire So I made a new lint to do this (basically following the tutorial), but I am wondering if it would be better to instead add this as an extra case of lint_search_is_some() in methods/mod.rs?

[pickfire]

@rsulli55 Not quite sure but probably good. Maybe you can take inspiration from find_map() https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/methods/mod.rs#L2905?

[rsulli55]

@pickfire Ok, thanks! I opened a WIP PR for now with what I have but I will be happy to move the code around if it should be placed somewhere else.