Skip to content

Configuration variable for wildcard_imports to always warn #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dylni opened this issue May 5, 2020 · 0 comments · Fixed by #5564
Closed

Configuration variable for wildcard_imports to always warn #5569

dylni opened this issue May 5, 2020 · 0 comments · Fixed by #5564
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good first issue These issues are a good way to get started with Clippy

Comments

@dylni
Copy link

dylni commented May 5, 2020

Suggested on this pull request:

Since wildcard_imports is starting to warn in less cases, should it have a configuration variable to always warn? That would also help make the documentation clearer about it not warning in all cases by default.

It would be helpful if a configuration variable is added to wildcard_imports that skips checking for:

This might be a good first issue.
@flip1995 flip1995 added good first issue These issues are a good way to get started with Clippy C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels May 5, 2020
@MrAwesome MrAwesome mentioned this issue May 7, 2020
Merged
@bors bors closed this as completed in 43a1777 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good first issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow use super::*; glob imports MrAwesome/rust-clippy
2 participants
@flip1995 @dylni