Skip to content

does not compile with rustc 1.15.0-nightly (1c448574b 2016-11-28) #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
durka opened this issue Nov 30, 2016 · 17 comments · Fixed by #1373
Closed

does not compile with rustc 1.15.0-nightly (1c448574b 2016-11-28) #1371

durka opened this issue Nov 30, 2016 · 17 comments · Fixed by #1373
Assignees
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@durka
Copy link
Contributor

durka commented Nov 30, 2016

A ton of stuff seems to have been renamed. Errors can be seen here: https://travis-ci.org/durka/guard/jobs/180149918#L253

@mcarton mcarton added the C-bug Category: Clippy is not doing the correct thing label Nov 30, 2016
@oli-obk oli-obk self-assigned this Dec 1, 2016
@oli-obk
Copy link
Contributor

oli-obk commented Dec 1, 2016

on it

@oli-obk
Copy link
Contributor

oli-obk commented Dec 1, 2016

this is not a fun one... I'm compiling already, but getting crashes in rustc and clippy when testing...

@oli-obk oli-obk mentioned this issue Dec 1, 2016
@nordlow
Copy link

nordlow commented Dec 6, 2016

Does it compile with 1.13 or 1.14?

@mcarton
Copy link
Member

mcarton commented Dec 6, 2016

It compiles with rustc 1.15.0-nightly (2217bd7 2016-11-25).
The latest version of clippy won't compile on versions as old as 1.13 or 1.14 though. It requires (and has always required) a recent nightly (usually the latest, but we've ran into some problems with that one).

@nbigaouette
Copy link

I was able to compile/install clippy yesterday using a nightly from November 25th. That's the last one that worked for me.

rustup toolchain install nightly-2016-11-25
rustup run nightly-2016-11-25 cargo install clippy
rustup run nightly-2016-11-25 cargo clippy

@nordlow
Copy link

nordlow commented Dec 6, 2016

Should I start with

curl -sSf https://static.rust-lang.org/rustup.sh | sh -s -- --channel=nightly

?

@nbigaouette
Copy link

nbigaouette commented Dec 6, 2016

@nordlow use https://rustup.rs/ instead. Not yet official, but close! It is official, just not 100% ready yet.

@nordlow
Copy link

nordlow commented Dec 6, 2016

Ok, I'm trying it out now. I chose nightly. Ok?

@nbigaouette
Copy link

Just follow the instruction from the site to install it (it's going to ask you questions, can't remember which ones though).

Once rustup is installed, just run the three commands I've posted:

rustup toolchain install nightly-2016-11-25
rustup run nightly-2016-11-25 cargo install clippy
rustup run nightly-2016-11-25 cargo clippy

This will install clippy using the nightly from November 25th, and run it on your code base.

You can always install a "latest" nightly, beta or stable. Refer to https://github.com/rust-lang-nursery/rustup.rs for more info.

@nordlow
Copy link

nordlow commented Dec 6, 2016

What does cargo clippy do? Activate it as a compiler plugin?

@bbigras
Copy link

bbigras commented Dec 6, 2016

What does cargo clippy do?

It runs clippy on the current project.

@nbigaouette
Copy link

Clippy can be run multiple ways. One of those is through a "cargo-clippy" binary, which was installed using cargo install clippy.

I basically runs clippy on your files, without having to annotate the source files or add clippy to your Cargo.toml.

@nordlow
Copy link

nordlow commented Dec 6, 2016

I could run it as

rustup run nightly-2016-11-25 cargo build

aswell! I guess this runs it as a rustc plugin, right? This awesome!

@nbigaouette
Copy link

yes ;)

@nordlow
Copy link

nordlow commented Dec 6, 2016

My Cargo bash completion has stopped working. Previously, it was placed in /usr/local/etc/bash_completion.d/cargo. I can't find it now.

@lambda-fairy
Copy link

@nordlow If you'd like help using Rust or Cargo, I suggest asking on the users' forum instead.

@nordlow
Copy link

nordlow commented Dec 7, 2016

Ok, thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants