Skip to content

Activate rustc deprecated_in_future lint by default in clippy #11323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Urgau opened this issue Aug 11, 2023 · 1 comment
Open

Activate rustc deprecated_in_future lint by default in clippy #11323

Urgau opened this issue Aug 11, 2023 · 1 comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages

Comments

@Urgau
Copy link
Member

Urgau commented Aug 11, 2023

Description

rustc has an allow-by-default lint deprecated_in_future, which does the same thing as deprecated, except that the lint is allow-by-default instead of warn or higher.

By being allow-by-default makes sense for rustc, as the intention is not to warn unnecessarily when it's not 100% required; but I think that making the lint warn-by-default with clippy would make a lot of sense, as clippy is by nature more relaxed on things that it lints on, and linting on deprecated in future usage would be something that clippy users might want.

Related to #10997 where we are trying to lint on deprecated in future items. cc @Centri3

Version

No response

Additional Labels

@rustbot label +C-enhancement

@rustbot rustbot added the C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages label Aug 11, 2023
@Centri3
Copy link
Member

Centri3 commented Aug 12, 2023

I was always a bit confused why this lint was allow-by-default (or more importantly, internal); it seems it'd be something lovely, since deprecated-in-future usually doesn't come around overnight.

Also, currently the only things deprecated-in-future are the legacy constants, I thought of bringing it up there but I never got around to it.

I'm definitely in favor of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages
Projects
None yet
Development

No branches or pull requests

3 participants