`while_let_loop` should not be reported for empty match statements

[DzenanJupic]

Description

In case the loop only contains a single match statement, with either an empty block or a break, while_let_loop should IMO not be reported, since the code communicates a slightly different intention.

A loop with a single, empty match communicates, that driving the iterator/stream/generator/... to completion is the main focus, while a while loop communicates, that the iterator/stream/generator/... is just a source of data and not the main focus.

loop {
    match state.process_next() {
        ControlFlow::Continue(_) => {},
        ControlFlow::Break(_) => break,
    }
}

while let ControlFlow::Continue(_) = state.process_next() {}

Small example: playground

Version

rustc 1.67.0-nightly (a00f8ba7f 2022-11-15)
binary: rustc
commit-hash: a00f8ba7fcac1b27341679c51bf5a3271fa82df3
commit-date: 2022-11-15
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4

(also on stable)

Additional Labels

No response

[PartiallyUntyped]

@rustbot label +False-positive

[rustbot]

Error: Label False-positive can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[ada4a]

@rustbot label I-false-positive