Also inspect doc code blocks

Author: blyxyas

clippy_lints/src/doc.rs

@@ -649,7 +649,9 @@ fn check_doc<'a, Events: Iterator<Item = (pulldown_cmark::Event<'a>, Range<usize
                 headers.safety |= in_heading && trimmed_text == "Implementation safety";
                 headers.safety |= in_heading && trimmed_text == "Implementation Safety";
                 headers.errors |= in_heading && trimmed_text == "Errors";
+                headers.errors |= trimmed_text.contains("# Errors\n"); // For /** Doc comments */
                 headers.panics |= in_heading && trimmed_text == "Panics";
+                headers.panics |= trimmed_text.contains("# Panics\n");
                 if in_code {
                     if is_rust && !no_test {
                         let edition = edition.unwrap_or_else(|| cx.tcx.sess.edition());

tests/ui/doc_errors.rs

@@ -63,6 +63,21 @@ impl Struct1 {
         unimplemented!();
     }
 
+    /**
+    # Errors
+    Hi
+     */
+    pub fn pub_method_with_block_errors_header() -> Result<(), ()> {
+        unimplemented!();
+    }
+
+    /**
+    This is not sufficiently documented.
+     */
+    pub fn pub_method_missing_block_errors_header() -> Result<(), ()> {
+        unimplemented!();
+    }
+
     /// # Errors
     /// A description of the errors goes here.
     pub async fn async_pub_method_with_errors_header() -> Result<(), ()> {

tests/ui/doc_errors.stderr

@@ -37,10 +37,16 @@ LL |     pub async fn async_pub_method_missing_errors_header() -> Result<(), ()>
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: docs for function returning `Result` missing `# Errors` section
-  --> $DIR/doc_errors.rs:85:5
+  --> $DIR/doc_errors.rs:77:5
+   |
+LL |     pub fn pub_method_missing_block_errors_header() -> Result<(), ()> {
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: docs for function returning `Result` missing `# Errors` section
+  --> $DIR/doc_errors.rs:100:5
    |
 LL |     fn trait_method_missing_errors_header() -> Result<(), ()>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 7 previous errors
+error: aborting due to 8 previous errors
 

tests/ui/missing_panics_doc.rs

@@ -114,6 +114,21 @@ pub fn assert_ne_documented() {
     assert_ne!(x, 0);
 }
 
+/**
+# Panics
+A reason
+*/
+pub fn panic_documented_in_block() {
+    panic!();
+}
+
+/**
+ <Cool documentation here>
+*/
+pub fn panic_undocumented_in_block() {
+    panic!();
+}
+
 /// This is okay because it is private
 fn unwrap_private() {
     let result = Err("Hi");

tests/ui/missing_panics_doc.stderr

@@ -83,6 +83,18 @@ note: first possible panic found here
 LL |     assert_ne!(x, 0);
    |     ^^^^^^^^^^^^^^^^
 
+error: docs for function which may panic missing `# Panics` section
+  --> $DIR/missing_panics_doc.rs:128:1
+   |
+LL | pub fn panic_undocumented_in_block() {
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+note: first possible panic found here
+  --> $DIR/missing_panics_doc.rs:129:5
+   |
+LL |     panic!();
+   |     ^^^^^^^^
+
 error: docs for function which may panic missing `# Panics` section
   --> $DIR/missing_panics_doc.rs:158:5
    |
@@ -114,7 +126,7 @@ LL |     pub fn result_unwrap<T>(v: &[T]) -> &T {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
 note: first possible panic found here
-  --> $DIR/missing_panics_doc.rs:170:9
+  --> $DIR/missing_panics_doc.rs:180:9
    |
 LL |         res.unwrap()
    |         ^^^^^^^^^^^^