Reimplement lint using EarlyLintPass::check_crate

Author: popzxc

clippy_lints/src/disallowed_script_idents.rs

@@ -1,7 +1,7 @@
 use clippy_utils::diagnostics::span_lint;
+use rustc_ast::ast;
 use rustc_data_structures::fx::FxHashSet;
-use rustc_hir::{Pat, PatKind};
-use rustc_lint::{LateContext, LateLintPass};
+use rustc_lint::{EarlyContext, EarlyLintPass, Level};
 use rustc_session::{declare_tool_lint, impl_lint_pass};
 use unicode_script::{Script, UnicodeScript};
 
@@ -59,34 +59,46 @@ impl DisallowedScriptIdents {
 
 impl_lint_pass!(DisallowedScriptIdents => [DISALLOWED_SCRIPT_IDENTS]);
 
-impl<'tcx> LateLintPass<'tcx> for DisallowedScriptIdents {
-    fn check_pat(&mut self, cx: &LateContext<'tcx>, pat: &'tcx Pat<'_>) {
-        let ident = if let PatKind::Binding(.., ident, _) = pat.kind {
-            ident
-        } else {
-            return;
-        };
+impl EarlyLintPass for DisallowedScriptIdents {
+    fn check_crate(&mut self, cx: &EarlyContext<'_>, _: &ast::Crate) {
+        // Implementation is heavily inspired by the implementation of [`non_ascii_idents`] lint:
+        // https://github.com/rust-lang/rust/blob/master/compiler/rustc_lint/src/non_ascii_idents.rs
+
+        let check_disallowed_script_idents = cx.builder.lint_level(DISALLOWED_SCRIPT_IDENTS).0 != Level::Allow;
 
-        if ident.as_str().is_ascii() {
-            // Fully-ASCII identifiers are valid by default, no need to analyze them further.
+        if !check_disallowed_script_idents {
             return;
         }
 
-        for symbol in ident.name.as_str().chars() {
-            let script = symbol.script();
-            if !self.whitelist.contains(&script) {
-                span_lint(
-                    cx,
-                    DISALLOWED_SCRIPT_IDENTS,
-                    ident.span,
-                    &format!(
-                        "identifier `{}` has a Unicode script that is not allowed by configuration: {}",
-                        ident.name,
-                        script.full_name()
-                    ),
-                );
-                // We don't want to spawn warning multiple times over a single identifier.
-                break;
+        let symbols = cx.sess.parse_sess.symbol_gallery.symbols.lock();
+
+        // Sort by `Span` so that error messages make sense with respect to the
+        // order of identifier locations in the code.
+        let mut symbols: Vec<_> = symbols.iter().collect();
+        symbols.sort_unstable_by_key(|k| k.1);
+
+        for (symbol, &span) in &symbols {
+            let symbol_str = symbol.as_str();
+            if symbol_str.is_ascii() {
+                continue;
+            }
+
+            for c in symbol_str.chars() {
+                let script = c.script();
+                if !self.whitelist.contains(&script) {
+                    span_lint(
+                        cx,
+                        DISALLOWED_SCRIPT_IDENTS,
+                        span,
+                        &format!(
+                            "identifier `{}` has a Unicode script that is not allowed by configuration: {}",
+                            symbol_str,
+                            script.full_name()
+                        ),
+                    );
+                    // We don't want to spawn warning multiple times over a single identifier.
+                    break;
+                }
             }
         }
     }

clippy_lints/src/lib.rs

@@ -2086,7 +2086,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     let import_renames = conf.enforced_import_renames.clone();
     store.register_late_pass(move || box missing_enforced_import_rename::ImportRename::new(import_renames.clone()));
     let scripts = conf.allowed_scripts.clone();
-    store.register_late_pass(move || box disallowed_script_idents::DisallowedScriptIdents::new(scripts.clone()));
+    store.register_early_pass(move || box disallowed_script_idents::DisallowedScriptIdents::new(scripts.clone()));
 }
 
 #[rustfmt::skip]