Do not lint if only has MaybeUninit fields

Author: Centri3

clippy_lints/src/incorrect_impls.rs

@@ -1,9 +1,14 @@
-use clippy_utils::{diagnostics::span_lint_and_sugg, get_parent_node, last_path_segment, ty::implements_trait};
+use clippy_utils::{
+    diagnostics::span_lint_and_sugg,
+    get_parent_node, last_path_segment,
+    ty::{implements_trait, is_type_lang_item},
+};
+use itertools::Itertools;
 use rustc_errors::Applicability;
-use rustc_hir::{ExprKind, ImplItem, ImplItemKind, ItemKind, Node, UnOp};
+use rustc_hir::{ExprKind, ImplItem, ImplItemKind, ItemKind, LangItem, Node, UnOp};
 use rustc_hir_analysis::hir_ty_to_ty;
 use rustc_lint::{LateContext, LateLintPass};
-use rustc_middle::ty::EarlyBinder;
+use rustc_middle::ty::{self, EarlyBinder};
 use rustc_session::{declare_lint_pass, declare_tool_lint};
 use rustc_span::{sym, symbol};
 
@@ -15,6 +20,14 @@ declare_clippy_lint! {
     /// If both `Clone` and `Copy` are implemented, they must agree. This is done by dereferencing
     /// `self` in `Clone`'s implementation. Anything else is incorrect.
     ///
+    /// ### Known issues
+    /// While anything other than `*self` is *technically* incorrect, it can often be done as an
+    /// optimization, like in the case of `MaybeUninit` for example. Returning a new `MaybeUninit`
+    /// is both faster and as correct as `memcpy`ing the original. If this is not the case however,
+    /// the lint's advice should almost always be applied.
+    ///
+    /// Note: This lint ignores `Clone` implementations on types that are just `MaybeUninit`.
+    ///
     /// ### Example
     /// ```rust,ignore
     /// #[derive(Eq, PartialEq)]
@@ -43,7 +56,7 @@ declare_clippy_lint! {
     /// ```
     #[clippy::version = "1.72.0"]
     pub INCORRECT_CLONE_IMPL_ON_COPY_TYPE,
-    correctness,
+    complexity,
     "manual implementation of `Clone` on a `Copy` type"
 }
 declare_lint_pass!(IncorrectImpls => [INCORRECT_CLONE_IMPL_ON_COPY_TYPE]);
@@ -84,7 +97,31 @@ impl LateLintPass<'_> for IncorrectImpls {
                     copy_def_id,
                     trait_impl.substs,
                 )
+            && let ty::Adt(def, substs) = hir_ty_to_ty(cx.tcx, imp.self_ty).kind()
         {
+            let fields = def.all_fields().collect_vec();
+            // Necessary as `all` returns true on an empty iterator
+            if !fields.is_empty()
+                && fields.iter().all(|field| {
+                    let ty = field.ty(cx.tcx, substs);
+
+                    match ty.kind() {
+                        // `MaybeUninit<T>`
+                        ty::Adt(_, _) if is_type_lang_item(cx, ty, LangItem::MaybeUninit) => true,
+                        // `[MaybeUninit<T>; N]`
+                        ty::Array(inner_ty, _) | ty::Slice(inner_ty)
+                            if is_type_lang_item(cx, *inner_ty, LangItem::MaybeUninit) =>
+                        {
+                            true
+                        },
+                        // Other cases are likely pretty rare.
+                        _ => false,
+                    }
+                })
+            {
+                return;
+            }
+
             if impl_item.ident.name == sym::clone {
                 if block.stmts.is_empty()
                     && let Some(expr) = block.expr

tests/ui/incorrect_clone_impl_on_copy_type.fixed

@@ -95,3 +95,14 @@ impl<A: Copy> Clone for Uwu<A> {
 }
 
 impl<A: std::fmt::Debug + Copy + Clone> Copy for Uwu<A> {}
+
+// do not lint if type has only `MaybeUninit` fields
+struct G([std::mem::MaybeUninit<u32>; 100]);
+
+impl Clone for G {
+    fn clone(&self) -> Self {
+        todo!()
+    }
+}
+
+impl Copy for G {}

tests/ui/incorrect_clone_impl_on_copy_type.rs

@@ -105,3 +105,14 @@ impl<A: Copy> Clone for Uwu<A> {
 }
 
 impl<A: std::fmt::Debug + Copy + Clone> Copy for Uwu<A> {}
+
+// do not lint if type has only `MaybeUninit` fields
+struct G([std::mem::MaybeUninit<u32>; 100]);
+
+impl Clone for G {
+    fn clone(&self) -> Self {
+        todo!()
+    }
+}
+
+impl Copy for G {}

tests/ui/incorrect_clone_impl_on_copy_type.stderr

@@ -7,7 +7,7 @@ LL | |         Self(self.0)
 LL | |     }
    | |_____^ help: change this to: `{ *self }`
    |
-   = note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
+   = note: `-D clippy::incorrect-clone-impl-on-copy-type` implied by `-D warnings`
 
 error: incorrect implementation of `clone_from` on a `Copy` type
   --> $DIR/incorrect_clone_impl_on_copy_type.rs:14:5