handle astriks

Author: nyurik

clippy_utils/src/macros.rs

@@ -564,9 +564,10 @@ fn span_from_inner(base: SpanData, inner: rpf::InnerSpan) -> Span {
 pub enum FormatParamKind {
     /// An implicit parameter , such as `{}` or `{:?}`.
     Implicit,
-    /// A parameter with an explicit number, or an asterisk precision. e.g. `{1}`, `{0:?}`,
-    /// `{:.0$}` or `{:.*}`.
+    /// A parameter with an explicit number, e.g. `{1}`, `{0:?}`, or `{:.0$}`
     Numbered,
+    /// A parameter with an asterisk precision. e.g. `{:.*}`.
+    Stared,
     /// A named parameter with a named `value_arg`, such as the `x` in `format!("{x}", x = 1)`.
     Named(Symbol),
     /// An implicit named parameter, such as the `y` in `format!("{y}")`.
@@ -646,9 +647,12 @@ impl<'tcx> Count<'tcx> {
                 span,
                 values,
             )?),
-            rpf::Count::CountIsParam(_) | rpf::Count::CountIsStar(_) => {
+            rpf::Count::CountIsParam(_) => {
                 Self::Param(FormatParam::new(FormatParamKind::Numbered, position?, inner?, values)?)
             },
+            rpf::Count::CountIsStar(_)  => {
+                Self::Param(FormatParam::new(FormatParamKind::Stared, position?, inner?, values)?)
+            },
             rpf::Count::CountImplied => Self::Implied,
         })
     }

tests/ui/inline_format_args.fixed

@@ -37,8 +37,8 @@ fn tester(fn_arg: i32) {
     println!("{local_i32:<3}");
     println!("{local_i32:#010x}");
     println!("{local_f64:.1}");
-    println!("Hello {} is {:.*}", "x", local_i32, local_f64);
-    println!("Hello {} is {:.*}", local_i32, 5, local_f64);
+    println!("Hello {} is {local_f64:.*}", "x", local_i32);
+    println!("Hello {local_i32} is {local_f64:.*}", 5);
     println!("Hello {} is {2:.*}", local_i32, 5, local_f64);
     println!("{local_i32} {local_f64}");
     println!("{local_i32}, {}", local_opt.unwrap());

tests/ui/inline_format_args.stderr

@@ -183,6 +183,30 @@ LL -     println!("{:.1}", local_f64);
 LL +     println!("{local_f64:.1}");
    |
 
+error: variables can be used directly in the `format!` string
+  --> $DIR/inline_format_args.rs:42:5
+   |
+LL |     println!("Hello {} is {:.*}", "x", local_i32, local_f64);
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: change this to
+   |
+LL -     println!("Hello {} is {:.*}", "x", local_i32, local_f64);
+LL +     println!("Hello {} is {local_f64:.*}", "x", local_i32);
+   |
+
+error: variables can be used directly in the `format!` string
+  --> $DIR/inline_format_args.rs:43:5
+   |
+LL |     println!("Hello {} is {:.*}", local_i32, 5, local_f64);
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: change this to
+   |
+LL -     println!("Hello {} is {:.*}", local_i32, 5, local_f64);
+LL +     println!("Hello {local_i32} is {local_f64:.*}", 5);
+   |
+
 error: variables can be used directly in the `format!` string
   --> $DIR/inline_format_args.rs:45:5
    |
@@ -279,5 +303,5 @@ LL -     println!("{}", format!("{}", local_i32));
 LL +     println!("{}", format!("{local_i32}"));
    |
 
-error: aborting due to 23 previous errors
+error: aborting due to 25 previous errors