Refactored the check for two spans on the same line

Author: 1c3t3a

clippy_lints/src/semicolon_if_nothing_returned.rs

@@ -1,6 +1,7 @@
 use clippy_utils::diagnostics::span_lint_and_sugg;
 use clippy_utils::source::snippet_with_macro_callsite;
-use clippy_utils::{get_parent_expr_for_hir, in_macro, spans_on_same_line, sugg};
+use clippy_utils::{get_parent_expr_for_hir, in_macro, sugg};
+use crate::rustc_lint::LintContext;
 use if_chain::if_chain;
 use rustc_errors::Applicability;
 use rustc_hir::Expr;
@@ -82,8 +83,9 @@ fn check_if_inside_block_on_same_line<'tcx>(
         matches!(parent.kind, ExprKind::Closure(..) | ExprKind::Block(..));
 
         if block.stmts.is_empty();
+        let source_map = cx.sess().source_map();
         then {
-            return spans_on_same_line(cx, parent.span, last_expr.span);
+            return !source_map.is_multiline(parent.span.to(last_expr.span));
         }
     }
     false

clippy_utils/src/lib.rs

@@ -820,11 +820,6 @@ fn line_span<T: LintContext>(cx: &T, span: Span) -> Span {
     Span::new(line_start, span.hi(), span.ctxt())
 }
 
-/// Checks if two spans begin on the same line.
-pub fn spans_on_same_line<T: LintContext>(cx: &T, left_span: Span, right_span: Span) -> bool {
-    line_span(cx, left_span).lo() == line_span(cx, right_span).lo()
-}
-
 /// Gets the parent node, if any.
 pub fn get_parent_node(tcx: TyCtxt<'_>, id: HirId) -> Option<Node<'_>> {
     tcx.hir().parent_iter(id).next().map(|(_, node)| node)