Skip to content

Commit 2c16df1

Browse files
committed
chore
1 parent 879c9f7 commit 2c16df1

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

clippy_lints/src/lib.rs

-1
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
857857
store.register_late_pass(move || Box::new(borrow_as_ptr::BorrowAsPtr::new(msrv)));
858858
store.register_late_pass(move || Box::new(manual_bits::ManualBits::new(msrv)));
859859
store.register_late_pass(|| Box::new(default_union_representation::DefaultUnionRepresentation));
860-
store.register_late_pass(|| Box::new(map_then_identity_transformer::MapThenIdentityTransformer));
861860
store.register_late_pass(|| Box::new(dbg_macro::DbgMacro));
862861
let cargo_ignore_publish = conf.cargo_ignore_publish;
863862
store.register_late_pass(move || {

clippy_lints/src/methods/mod.rs

+8-3
Original file line numberDiff line numberDiff line change
@@ -2346,7 +2346,7 @@ fn check_methods<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, msrv: Optio
23462346
("add" | "offset" | "sub" | "wrapping_offset" | "wrapping_add" | "wrapping_sub", [_arg]) => {
23472347
zst_offset::check(cx, expr, recv);
23482348
},
2349-
(name @ ("all" | "any" | "find_map" | "position"), [arg]) => {
2349+
(name @ ("all" | "any" | "position"), [arg]) => {
23502350
if let Some((name2 @ "map", [_, arg2], span2)) = method_call(recv) {
23512351
map_then_identity_transformer::check(cx, span2, name2, arg2, name, arg);
23522352
}
@@ -2404,8 +2404,13 @@ fn check_methods<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, msrv: Optio
24042404
}
24052405
}
24062406
},
2407-
("find_map", [arg]) => {
2408-
unnecessary_filter_map::check(cx, expr, arg, name);
2407+
(name @ "find_map", [arg]) => {
2408+
let triggered = unnecessary_filter_map::check(cx, expr, arg, name);
2409+
if !triggered {
2410+
if let Some((name2 @ "map", [_, arg2], span2)) = method_call(recv) {
2411+
map_then_identity_transformer::check(cx, span2, name2, arg2, name, arg);
2412+
}
2413+
}
24092414
},
24102415
(name @ "flat_map", [arg]) => {
24112416
let triggered = flat_map_identity::check(cx, expr, arg, span);

clippy_lints/src/methods/unnecessary_filter_map.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, arg: &hir::Expr<
4343
{
4444
if name == "filter_map" { "filter" } else { "find" }
4545
},
46-
_ => {
47-
return false
48-
},
46+
_ => return false,
4947
}
5048
} else {
5149
return false;

0 commit comments

Comments
 (0)