fixup! CI: Move fmt test to its previous place

Author: flip1995

.github/workflows/clippy.yml

@@ -27,6 +27,7 @@ env:
 
 jobs:
   base:
+    # NOTE: If you modify this job, make sure you copy the changes to clippy_bors.yml
     runs-on: ubuntu-latest
 
     steps:
@@ -64,8 +65,8 @@ jobs:
       run: cargo test --features deny-warnings
       working-directory: rustc_tools_util
 
-    - name: Test clippy_dev
-      run: cargo test --features deny-warnings
+    - name: Test clippy_dev and lintcheck
+      run: cargo test --features lintcheck,deny-warnings
       working-directory: clippy_dev
 
     - name: Test cargo-clippy

.github/workflows/clippy_bors.yml

@@ -72,6 +72,7 @@ jobs:
 
     runs-on: ${{ matrix.os }}
 
+    # NOTE: If you modify this job, make sure you copy the changes to clippy.yml
     steps:
     # Setup
     - uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
@@ -112,6 +113,9 @@ jobs:
     - name: Build
       run: cargo build --features deny-warnings,internal-lints
 
+    - name: Test "--fix -Zunstable-options"
+      run: cargo run --features deny-warnings,internal-lints --bin cargo-clippy -- clippy --fix -Zunstable-options
+
     - name: Test
       run: cargo test --features deny-warnings,internal-lints
 
@@ -123,8 +127,8 @@ jobs:
       run: cargo test --features deny-warnings
       working-directory: rustc_tools_util
 
-    - name: Test clippy_dev
-      run: cargo test --features deny-warnings
+    - name: Test clippy_dev and lintcheck
+      run: cargo test --features lintcheck,deny-warnings
       working-directory: clippy_dev
 
     - name: Test cargo-clippy
@@ -136,6 +140,13 @@ jobs:
       env:
         OS: ${{ runner.os }}
 
+    - name: Test cargo dev new lint
+      run: |
+        cargo dev new_lint --name new_early_pass --pass early
+        cargo dev new_lint --name new_late_pass --pass late
+        cargo check
+        git reset --hard HEAD
+
   integration_build:
     needs: changelog
     runs-on: ubuntu-latest

.github/workflows/clippy_dev.yml

@@ -8,10 +8,10 @@ on:
   pull_request:
     # Only run on paths, that get checked by the clippy_dev tool
     paths:
-      - "CHANGELOG.md"
-      - "README.md"
-      - "**.stderr"
-      - "**.rs"
+    - 'CHANGELOG.md'
+    - 'README.md'
+    - '**.stderr'
+    - '**.rs'
 
 env:
   RUST_BACKTRACE: 1
@@ -21,49 +21,35 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      # Setup
-      - name: Checkout
-        uses: actions/[email protected]
-
-      # To test formatting, we need to temporarily disable the rust-toolchain file
-      - name: remove toolchain file
-        run: rm rust-toolchain
-
-      - name: rust-toolchain
-        uses: actions-rs/[email protected]
-        with:
-          toolchain: nightly
-          target: x86_64-unknown-linux-gnu
-          profile: minimal
-          components: rustfmt
-          default: true
-
-      # Run
-      - name: Build
-        run: cargo build --features deny-warnings
-        working-directory: clippy_dev
-
-      - name: Test limit_stderr_length
-        run: cargo dev limit_stderr_length
-
-      - name: Test update_lints
-        run: cargo dev update_lints --check
-
-      - name: Test fmt
-        run: cargo dev fmt --check
-
-      # Restore the rust-toolchain-file
-      - name: Restore rust-toolchain-file
-        run: git checkout rust-toolchain
-
-      # Lintcheck
-      - name: build lintcheck
-        run: cargo build --features lintcheck,deny-warnings
-        working-directory: clippy_dev
-
-      - name: test lintcheck
-        run: cargo test --features lintcheck,deny-warnings
-        working-directory: clippy_dev
+    # Setup
+    - name: Checkout
+      uses: actions/[email protected]
+
+    - name: remove toolchain file
+      run: rm rust-toolchain
+
+    - name: rust-toolchain
+      uses: actions-rs/[email protected]
+      with:
+        toolchain: nightly
+        target: x86_64-unknown-linux-gnu
+        profile: minimal
+        components: rustfmt
+        default: true
+
+    # Run
+    - name: Build
+      run: cargo build --features deny-warnings
+      working-directory: clippy_dev
+
+    - name: Test limit_stderr_length
+      run: cargo dev limit_stderr_length
+
+    - name: Test update_lints
+      run: cargo dev update_lints --check
+
+    - name: Test fmt
+      run: cargo dev fmt --check
 
   # These jobs doesn't actually test anything, but they're only used to tell
   # bors the build completed, as there is no practical way to detect when a