Skip to content

Figure out a way to quiet test expectations' warning spew #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fitzgen opened this issue Dec 29, 2016 · 5 comments
Closed

Figure out a way to quiet test expectations' warning spew #373

fitzgen opened this issue Dec 29, 2016 · 5 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Dec 29, 2016

They are so noisy with style warnings (eg camel case and capitalization) that we expect to fail. Makes reading the test results harder than it should be.

Perhaps we should insert

#![allow(non_camel_case)]; // or whatever the exact incantation is
// etc...

by default?

@emilio
Copy link
Contributor

emilio commented Dec 29, 2016

It should be easy to just insert that in the test results with raw_line, or in the module, right?

@fitzgen
Copy link
Member Author

fitzgen commented Dec 29, 2016

While we can easily do this with raw_line, I wanted to avoid

  • editing every test header manually
  • doing something specific that pretty much every general usage of bindgen wants to have

Therefore, I think we should put this in the codegen for modules (or only the top level module?)

@emilio
Copy link
Contributor

emilio commented Dec 29, 2016

I meant raw_line not as a flag in each test file, but as a configuration option in the builder, as we do for a few other things like no_unstable_rust.

I'm fine if we want to make it default I guess, but raw_line is easy to use and powerful enough to allow people choose whatever they want.

@emilio
Copy link
Contributor

emilio commented Apr 22, 2017

This is partially fixed in our tests, and we have other issues tracking the remaining work, if any.

@emilio emilio closed this as completed Apr 22, 2017
@jpochyla
Copy link

Sorry to dig into such an old issue, but how are bindgen users supposed to deal with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants