Skip to content

Publish diagnostics in two rounds #17731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Veykril opened this issue Jul 28, 2024 · 0 comments · Fixed by #17775
Closed

Publish diagnostics in two rounds #17731

Veykril opened this issue Jul 28, 2024 · 0 comments · Fixed by #17775
Labels
A-diagnostics diagnostics / error reporting A-perf performance issues Broken Window Bugs / technical debt to be addressed immediately

Comments

@Veykril
Copy link
Member

Veykril commented Jul 28, 2024

Our semantic diagnostics can take a while to compute depending on the project and file size, which unfortunately means that syntax errors are not very responsive right now, as we compute them together with the semantic ones and only publish them once those are done computing. We should handle these two separately, allowing for snappy syntax error reporting.

@Veykril Veykril added A-perf performance issues A-diagnostics diagnostics / error reporting Broken Window Bugs / technical debt to be addressed immediately labels Jul 28, 2024
@bors bors closed this as completed in f62d7b9 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics diagnostics / error reporting A-perf performance issues Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant