Duplicate "remove unnecessary parentheses" code action

[oriongonza]

if (true) {}

rust-analyzer version: 2023-10-16
rustc version: rustc 1.73.0 (cc66ad468 2023-10-03)

[omertuc]

One of them is a code assist that rust-analyzer is generating out of the output of a compiler warning (run cargo check and you'll see the string "remove these parentheses" in the warning, rust-analyzer knows how to turn these compiler suggestions into code assists and this is what you see in the code actions list), the other one ("Remove redundant parentheses") is coming from a built-in rust-analyzer assist to remove parenthesis.

The rust-analyzer one is even broken in some cases:

fn main() {
    match(true) {}
}

Becomes:

fn main() {
    matchtrue {}
}

Which is of-course invalid.

Maybe getting rid of the built-in rust-analyzer assist would be a better idea than trying to fix it? I don't know how much the built-in rust-analyzer code-assist and the compiler suggestions overlap in terms of functionality

[lnicola]

The built-in diagnostic works on-the-fly, without saving the file. Why should we get rid of it?

[omertuc]

Good point, haven't thought of that, thought it was simply redundant

[omertuc]

Created a separate ticket #15844 to address the issue I mentioned

[lnicola]

Let's close this, I don't think we can do much else about it.