Skip to content

"Implement Missing Members" assist shouldn't ignore doc(hidden) methods #15782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poliorcetics opened this issue Oct 19, 2023 · 2 comments · Fixed by #15854
Closed

"Implement Missing Members" assist shouldn't ignore doc(hidden) methods #15782

poliorcetics opened this issue Oct 19, 2023 · 2 comments · Fixed by #15854
Assignees
Labels
C-bug Category: bug

Comments

@poliorcetics
Copy link
Contributor

poliorcetics commented Oct 19, 2023

rust-analyzer version: (eg. output of "rust-analyzer: Show RA Version" command, accessible in VSCode via Ctrl/⌘+Shift+P) rust-analyzer 0.0.0 (4586a6b26 2023-10-18)

rustc version: (eg. output of rustc -V) rustc 1.73.0 (cc66ad468 2023-10-03)

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTC, RUSTUP_HOME or CARGO_HOME)

I'm trying to implement prost::Message for a type and using Implement Missing Members to generate the methods I need to actually write. It's missing the two doc(hidden) methods on the trait.

@poliorcetics poliorcetics added the C-bug Category: bug label Oct 19, 2023
@alibektas
Copy link
Member

@rustbot claim

@alibektas
Copy link
Member

With #14957 we started skipping implementing items with #[doc(hidden)] attributes. But I guess you have a fair point. It'd better if we changed it to : "Skip if you see doc(hidden) and no default implementation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants