Skip to content

Some keywords are not being highlighted #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaniPopes opened this issue May 16, 2023 · 5 comments
Closed

Some keywords are not being highlighted #14817

DaniPopes opened this issue May 16, 2023 · 5 comments
Labels
C-bug Category: bug

Comments

@DaniPopes
Copy link
Contributor

I don't know if this is actually a bug, but certain keywords like const, struct, fn etc are not being highlighted / italicized. This has been the case for pre-release versions in VSCode for the past few weeks, while the release version hasn't changed.

The only difference between the screenshots below is the version, all the settings are the same (semantic highlighting is enabled).

rustc version: rustc 1.71.0-nightly (ce5919fce 2023-05-15)

server stopped / no extension:

image

rust-analyzer release version: 0.3.1506-standalone

release

rust-analyzer pre-release version: 0.4.1510-standalone

image

@DaniPopes DaniPopes added the C-bug Category: bug label May 16, 2023
@Veykril
Copy link
Member

Veykril commented May 16, 2023

Ye I noticed this too, we now honor the augmentsSyntaxTokens capability #14777, but as it turns out the VSCode text mate grammar is not that great. Was thinking of what we can do here but I think we just need to disable it for now again.

@HKalbasi
Copy link
Member

Somehow unrelated, but this also breaks highlighting for ra_fixture.

@Veykril
Copy link
Member

Veykril commented May 16, 2023

That I already fixed (but the releases haven't gone out for that due to the marketplace token being expired)

@HKalbasi
Copy link
Member

Aha, thanks! I use my own builds, probably my branch is outdated.

@Veykril
Copy link
Member

Veykril commented May 16, 2023

#14795 shouldve fixed it

@Veykril Veykril closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants