Skip to content

"Rust Analyzer Language Server Trace" channel should only be created when tracing is enabled #13055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonas-schievink opened this issue Aug 18, 2022 · 0 comments · Fixed by #14067
Closed

"Rust Analyzer Language Server Trace" channel should only be created when tracing is enabled #13055

jonas-schievink opened this issue Aug 18, 2022 · 0 comments · Fixed by #14067
Labels
A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now

Comments

@jonas-schievink
Copy link
Contributor

Currently we always create 3 channels, which is a lot (other LSP extensions only use one). The trace channel is always empty unless server tracing is enabled, so it would be better to create it only when needed.
@jonas-schievink jonas-schievink added A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now labels Aug 18, 2022
@jonas-schievink jonas-schievink mentioned this issue Jan 31, 2023
Merged
@bors bors closed this as completed in 0fcef7f Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Lazily create the trace output channel
1 participant
@jonas-schievink