Skip to content

Commit ad6810e

Browse files
committed
Auto merge of #12475 - Veykril:trait-impl-completion, r=Veykril
fix: Fix trait impl completions using wrong insert position Fixes #12474
2 parents 995a17f + 0be31d9 commit ad6810e

File tree

1 file changed

+22
-1
lines changed

1 file changed

+22
-1
lines changed

crates/ide-completion/src/completions/item_list/trait_impl.rs

+22-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ fn completion_match(ctx: &CompletionContext) -> Option<(ImplCompletionKind, Text
118118
ImplCompletionKind::All,
119119
match nameref {
120120
Some(name) => name.syntax().text_range(),
121-
None => TextRange::empty(ctx.position.offset),
121+
None => ctx.source_range(),
122122
},
123123
ctx.impl_def.clone()?,
124124
)),
@@ -688,6 +688,27 @@ trait Test {
688688
type SomeType;
689689
}
690690
691+
impl Test for () {
692+
type SomeType = $0;\n\
693+
}
694+
",
695+
);
696+
check_edit(
697+
"type SomeType",
698+
r#"
699+
trait Test {
700+
type SomeType;
701+
}
702+
703+
impl Test for () {
704+
type$0
705+
}
706+
"#,
707+
"
708+
trait Test {
709+
type SomeType;
710+
}
711+
691712
impl Test for () {
692713
type SomeType = $0;\n\
693714
}

0 commit comments

Comments
 (0)