Auto merge of #17824 - ShoyuVanilla:fix-diags, r=Veykril

bors · bors · commit 9f69ed32b268 · 2024-08-07T14:47:34.000Z
fix: Native diagnostics not working This should be a `continue` now _Originally posted by `@Veykril` in #17775 (comment) I've tested the release compile output with IDE in the original PR, but my test workspace had only one `.rs` file 🤦 😢
diff --git a/crates/rust-analyzer/src/diagnostics.rs b/crates/rust-analyzer/src/diagnostics.rs
@@ -110,7 +110,7 @@ impl DiagnosticCollection {
                     })
                 {
                     // don't signal an update if the diagnostics are the same
-                    return;
+                    continue;
                 }
                 if *old_gen < generation || generation == 0 {
                     target.insert(file_id, (generation, diagnostics));

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ impl DiagnosticCollection {`
`110`	`110`	`})`
`111`	`111`	`{`
`112`	`112`	`// don't signal an update if the diagnostics are the same`
`113`		`- return;`
	`113`	`+ continue;`
`114`	`114`	`}`
`115`	`115`	`if *old_gen < generation \|\| generation == 0 {`
`116`	`116`	`target.insert(file_id, (generation, diagnostics));`