Skip to content

Commit 52bc15f

Browse files
committed
fix: Fix proc-macro-srv search paths for Arch Linux
1 parent e162d58 commit 52bc15f

File tree

3 files changed

+25
-48
lines changed

3 files changed

+25
-48
lines changed

crates/project-model/src/workspace.rs

+15
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,21 @@ impl ProjectWorkspace {
377377
}
378378
}
379379

380+
pub fn find_sysroot_proc_macro_srv(&self) -> Option<AbsPathBuf> {
381+
match self {
382+
ProjectWorkspace::Cargo { sysroot: Some(sysroot), .. }
383+
| ProjectWorkspace::Json { sysroot: Some(sysroot), .. } => {
384+
let standalone_server_name =
385+
format!("rust-analyzer-proc-macro-srv{}", std::env::consts::EXE_SUFFIX);
386+
["libexec", "lib"]
387+
.into_iter()
388+
.map(|segment| sysroot.root().join(segment).join(&standalone_server_name))
389+
.find(|server_path| std::fs::metadata(&server_path).is_ok())
390+
}
391+
_ => None,
392+
}
393+
}
394+
380395
/// Returns the roots for the current `ProjectWorkspace`
381396
/// The return type contains the path and whether or not
382397
/// the root is a member of the current workspace

crates/rust-analyzer/src/cli/load_cargo.rs

+5-17
Original file line numberDiff line numberDiff line change
@@ -60,24 +60,12 @@ pub fn load_workspace(
6060
};
6161

6262
let proc_macro_client = if load_config.with_proc_macro {
63-
let mut path = AbsPathBuf::assert(std::env::current_exe()?);
64-
let mut args = vec!["proc-macro"];
65-
66-
if let ProjectWorkspace::Cargo { sysroot, .. } | ProjectWorkspace::Json { sysroot, .. } =
67-
&ws
68-
{
69-
if let Some(sysroot) = sysroot.as_ref() {
70-
let standalone_server_name =
71-
format!("rust-analyzer-proc-macro-srv{}", std::env::consts::EXE_SUFFIX);
72-
let server_path = sysroot.root().join("libexec").join(&standalone_server_name);
73-
if std::fs::metadata(&server_path).is_ok() {
74-
path = server_path;
75-
args = vec![];
76-
}
77-
}
78-
}
63+
let (server_path, args): (_, &[_]) = match ws.find_sysroot_proc_macro_srv() {
64+
Some(server_path) => (server_path, &[]),
65+
None => (AbsPathBuf::assert(std::env::current_exe()?), &["proc-macro"]),
66+
};
7967

80-
ProcMacroServer::spawn(path.clone(), args.clone()).map_err(|e| e.to_string())
68+
ProcMacroServer::spawn(server_path, args).map_err(|e| e.to_string())
8169
} else {
8270
Err("proc macro server disabled".to_owned())
8371
};

crates/rust-analyzer/src/reload.rs

+5-31
Original file line numberDiff line numberDiff line change
@@ -305,50 +305,24 @@ impl GlobalState {
305305
let files_config = self.config.files();
306306
let project_folders = ProjectFolders::new(&self.workspaces, &files_config.exclude);
307307

308-
let standalone_server_name =
309-
format!("rust-analyzer-proc-macro-srv{}", std::env::consts::EXE_SUFFIX);
310-
311308
if self.proc_macro_clients.is_empty() {
312309
if let Some((path, path_manually_set)) = self.config.proc_macro_srv() {
313310
tracing::info!("Spawning proc-macro servers");
314311
self.proc_macro_clients = self
315312
.workspaces
316313
.iter()
317314
.map(|ws| {
318-
let (path, args) = if path_manually_set {
315+
let (path, args): (_, &[_]) = if path_manually_set {
319316
tracing::debug!(
320317
"Pro-macro server path explicitly set: {}",
321318
path.display()
322319
);
323-
(path.clone(), vec![])
320+
(path.clone(), &[])
324321
} else {
325-
let mut sysroot_server = None;
326-
if let ProjectWorkspace::Cargo { sysroot, .. }
327-
| ProjectWorkspace::Json { sysroot, .. } = ws
328-
{
329-
if let Some(sysroot) = sysroot.as_ref() {
330-
let server_path = sysroot
331-
.root()
332-
.join("libexec")
333-
.join(&standalone_server_name);
334-
if std::fs::metadata(&server_path).is_ok() {
335-
tracing::debug!(
336-
"Sysroot proc-macro server exists at {}",
337-
server_path.display()
338-
);
339-
sysroot_server = Some(server_path);
340-
} else {
341-
tracing::debug!(
342-
"Sysroot proc-macro server does not exist at {}",
343-
server_path.display()
344-
);
345-
}
346-
}
322+
match ws.find_sysroot_proc_macro_srv() {
323+
Some(server_path) => (server_path, &[]),
324+
None => (path.clone(), &["proc-macro"]),
347325
}
348-
sysroot_server.map_or_else(
349-
|| (path.clone(), vec!["proc-macro".to_owned()]),
350-
|path| (path, vec![]),
351-
)
352326
};
353327

354328
tracing::info!(?args, "Using proc-macro server at {}", path.display(),);

0 commit comments

Comments
 (0)