Skip to content

Failing wasm tests #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calebzulawski opened this issue Apr 11, 2021 · 3 comments · Fixed by #175
Closed

Failing wasm tests #92

calebzulawski opened this issue Apr 11, 2021 · 3 comments · Fixed by #175
Labels
O-Wasm WebAssembly's virtual architecture

Comments

@calebzulawski
Copy link
Member

calebzulawski commented Apr 11, 2021

I tracked down the cause of the wasm test failures and it looks like it's due to the comparison ops added to tests in #80. It looks like wasmparser has been updated to support these opcodes so it's just a matter of the changes propagating to wasm-bindgen-test. I opened rustwasm/wasm-bindgen#2522 to track this.

I think we can just ignore the failures for now and they should start passing against once wasm-bindgen-test is updated.

cc @workingjubilee

@calebzulawski calebzulawski added the O-Wasm WebAssembly's virtual architecture label Apr 11, 2021
@workingjubilee
Copy link
Member

I would like to find all the wasm tests that are currently failing on Chrome and disable them individually, but that might be asking too much.

@workingjubilee
Copy link
Member

workingjubilee commented Apr 16, 2021

This currently hinges on rustwasm/wasm-pack#998
To fix this we can either update our tests to no longer depend on using the wasm-pack binary, or wait.
I opened #96 to temporarily omit the wasm SIMD test suite in the meanwhile.

@workingjubilee
Copy link
Member

This actually was waiting for wasm-bindgen-cli to do an actual release, as it turns out. As Travis is broken, I will move the relevant wasm CI to GHA when I patch the tests back in and force an appropriate minimal wasm-bindgen version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Wasm WebAssembly's virtual architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants