Skip to content

Commit 68c7163

Browse files
Partially fix CI targets (rust-lang/packed-simd#355)
This fixes most CI targets that don't require special SDKs. A couple were named inaccurately, and that is also fixed, but it doesn't actually restore them to working order. Targets fixed by this merge: - [ ] "aarch-apple-ios" (aarch64-apple-ios) - [ ] aarch64-linux-android - [ ] aarch64-unknown-linux-gnu - [ ] "arm-linux-androideabi" (armv7-linux-androideabi) - [ ] i586-unknown-linux-gnu-SSE - [x] powerpc-unknown-linux-gnu - [x] powerpc64-unknown-linux-gnu - [x] powerpc64le-unknown-linux-gnu - [x] sparc64-unknown-linux-gnu - [x] s390x-unknown-linux-gnu - [ ] thumbv7neon-linux-android - [x] wasm32-unknown-unknown - [ ] x86_64-apple-ios - [x] x86_64-unknown-linux-android
2 parents ffce298 + 8a4d939 commit 68c7163

File tree

13 files changed

+38
-54
lines changed

13 files changed

+38
-54
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818
fail-fast: true
1919
with:
2020
target: x86_64-linux-android
21-
arm-linux-androideabi:
21+
armv7-linux-androideabi:
2222
uses: ./.github/workflows/run-ci-script.yml
2323
strategy:
2424
fail-fast: true
2525
with:
26-
target: arm-linux-androideabi
26+
target: armv7-linux-androideabi
2727
aarch64-unknown-linux-android-NEON:
2828
uses: ./.github/workflows/run-ci-script.yml
2929
strategy:
@@ -207,12 +207,12 @@ jobs:
207207
runner: macos-latest
208208
script: ci/run.sh
209209
target: x86_64-apple-ios
210-
aarch-apple-ios:
210+
aarch64-apple-ios:
211211
uses: ./.github/workflows/run-ci-script.yml
212212
strategy:
213213
fail-fast: true
214214
with:
215215
runner: macos-latest
216216
script: ci/run.sh
217-
target: aarch-apple-ios
217+
target: aarch64-apple-ios
218218
rustflags: -Ctarget-feature=+neon

.github/workflows/run-ci-script.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
VERIFY: ${{ inputs.verify }}
7878
FEATURES: ${{ inputs.features }}
7979
- name: Run CI Script
80-
timeout-minutes: 15
80+
timeout-minutes: 30
8181
run: ${{ inputs.script }}
8282
env:
8383
TARGET: ${{ inputs.target }}

Cargo.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ optional = true
3939

4040
[target.wasm32-unknown-unknown.dev-dependencies]
4141
# Keep in sync with the version on Dockerfile.
42-
wasm-bindgen = "=0.2.73"
43-
wasm-bindgen-test = "=0.3.23"
42+
wasm-bindgen = "=0.2.87"
43+
wasm-bindgen-test = "=0.3.37"

ci/android-install-ndk.sh

+7-23
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,11 @@
1111

1212
set -ex
1313

14-
curl --retry 5 -O https://dl.google.com/android/repository/android-ndk-r15b-linux-x86_64.zip
15-
unzip -q android-ndk-r15b-linux-x86_64.zip
14+
ANDROID_NDK_URL=https://dl.google.com/android/repository
15+
ANDROID_NDK_ARCHIVE=android-ndk-r25b-linux.zip
1616

17-
case "$1" in
18-
aarch64)
19-
arch=arm64
20-
;;
21-
22-
i686)
23-
arch=x86
24-
;;
25-
26-
*)
27-
arch=$1
28-
;;
29-
esac;
30-
31-
android-ndk-r15b/build/tools/make_standalone_toolchain.py \
32-
--unified-headers \
33-
--install-dir "/android/ndk-${1}" \
34-
--arch "${arch}" \
35-
--api 24
36-
37-
rm -rf ./android-ndk-r15b-linux-x86_64.zip ./android-ndk-r15b
17+
curl -fO "$ANDROID_NDK_URL/$ANDROID_NDK_ARCHIVE"
18+
unzip -q $ANDROID_NDK_ARCHIVE
19+
rm $ANDROID_NDK_ARCHIVE
20+
mv android-ndk-* ndk
21+
rm -rf android-ndk-*

ci/docker/powerpc-unknown-linux-gnu/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.04
1+
FROM ubuntu:22.04
22

33
RUN apt-get update && apt-get install -y --no-install-recommends \
44
gcc libc6-dev qemu-user ca-certificates \

ci/docker/powerpc64-unknown-linux-gnu/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.04
1+
FROM ubuntu:22.04
22

33
RUN apt-get update && apt-get install -y --no-install-recommends \
44
gcc \

ci/docker/powerpc64le-unknown-linux-gnu/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.04
1+
FROM ubuntu:22.04
22

33
RUN apt-get update && apt-get install -y --no-install-recommends \
44
gcc libc6-dev qemu-user ca-certificates \

ci/docker/s390x-unknown-linux-gnu/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.10
1+
FROM ubuntu:22.04
22

33
RUN apt-get update && \
44
apt-get install -y --no-install-recommends \
@@ -17,4 +17,4 @@ ENV CARGO_TARGET_S390X_UNKNOWN_LINUX_GNU_LINKER=s390x-linux-gnu-gcc \
1717
CARGO_TARGET_S390X_UNKNOWN_LINUX_GNU_RUNNER="qemu-s390x -L /usr/s390x-linux-gnu" \
1818
CC_s390x_unknown_linux_gnu=s390x-linux-gnu-gcc \
1919
CXX_s390x_unknown_linux_gnu=s390x-linux-gnu-g++ \
20-
OBJDUMP=s390x-linux-gnu-objdump
20+
OBJDUMP=s390x-linux-gnu-objdump

ci/docker/sparc64-unknown-linux-gnu/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM debian:stretch
1+
FROM debian:bookworm
22

33
RUN apt-get update && apt-get install -y --no-install-recommends \
44
curl ca-certificates \
@@ -15,4 +15,4 @@ COPY test-runner-linux /
1515
ENV CARGO_TARGET_SPARC64_UNKNOWN_LINUX_GNU_LINKER=sparc64-linux-gnu-gcc \
1616
CARGO_TARGET_SPARC64_UNKNOWN_LINUX_GNU_RUNNER="/test-runner-linux sparc64" \
1717
CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc \
18-
PATH=$PATH:/rust/bin
18+
PATH=$PATH:/rust/bin

ci/docker/wasm32-unknown-unknown/Dockerfile

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.04
1+
FROM ubuntu:22.04
22

33
RUN apt-get update -y && apt-get install -y --no-install-recommends \
44
ca-certificates \
@@ -8,7 +8,8 @@ RUN apt-get update -y && apt-get install -y --no-install-recommends \
88
git \
99
libc6-dev \
1010
make \
11-
python \
11+
ninja-build \
12+
python-is-python3 \
1213
xz-utils
1314

1415
# Install `wasm2wat`
@@ -17,10 +18,10 @@ RUN make -C wabt -j$(nproc)
1718
ENV PATH=$PATH:/wabt/bin
1819

1920
# Install `wasm-bindgen-test-runner`
20-
RUN curl -L https://github.com/rustwasm/wasm-bindgen/releases/download/0.2.73/wasm-bindgen-0.2.73-x86_64-unknown-linux-musl.tar.gz \
21+
RUN curl -L https://github.com/rustwasm/wasm-bindgen/releases/download/0.2.87/wasm-bindgen-0.2.87-x86_64-unknown-linux-musl.tar.gz \
2122
| tar xzf -
2223
# Keep in sync with the version on Cargo.toml.
23-
ENV PATH=$PATH:/wasm-bindgen-0.2.73-x86_64-unknown-linux-musl
24+
ENV PATH=$PATH:/wasm-bindgen-0.2.87-x86_64-unknown-linux-musl
2425
ENV CARGO_TARGET_WASM32_UNKNOWN_UNKNOWN_RUNNER=wasm-bindgen-test-runner
2526

2627
# Install `node`

ci/docker/x86_64-linux-android/Dockerfile

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:16.04
1+
FROM ubuntu:20.04
22

33
RUN apt-get update && \
44
apt-get install -y --no-install-recommends \
@@ -14,16 +14,18 @@ RUN apt-get update && \
1414
WORKDIR /android/
1515
ENV ANDROID_ARCH=x86_64
1616
COPY android-install-ndk.sh /android/
17-
RUN sh /android/android-install-ndk.sh $ANDROID_ARCH
17+
RUN sh /android/android-install-ndk.sh
18+
19+
ENV STDARCH_ASSERT_INSTR_LIMIT=30
1820

1921
# We do not run x86_64-linux-android tests on an android emulator.
2022
# See ci/android-sysimage.sh for informations about how tests are run.
2123
COPY android-sysimage.sh /android/
2224
RUN bash /android/android-sysimage.sh x86_64 x86_64-24_r07.zip
2325

24-
ENV PATH=$PATH:/rust/bin:/android/ndk-$ANDROID_ARCH/bin \
25-
CARGO_TARGET_X86_64_LINUX_ANDROID_LINKER=x86_64-linux-android-gcc \
26-
CC_x86_64_linux_android=x86_64-linux-android-gcc \
27-
CXX_x86_64_linux_android=x86_64-linux-android-g++ \
28-
OBJDUMP=x86_64-linux-android-objdump \
26+
ENV PATH=$PATH:/rust/bin:/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin \
27+
CARGO_TARGET_X86_64_LINUX_ANDROID_LINKER=x86_64-linux-android21-clang \
28+
CC_x86_64_linux_android=x86_64-linux-android21-clang \
29+
CXX_x86_64_linux_android=x86_64-linux-android21-clang++ \
30+
OBJDUMP=llvm-objdump \
2931
HOME=/tmp

src/api/bitmask.rs

+3-6
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,10 @@ macro_rules! impl_bitmask {
1717
test_if! {
1818
$test_tt:
1919
paste::item! {
20-
#[cfg(not(any(
20+
#[cfg(not(
2121
// FIXME: https://github.com/rust-lang-nursery/packed_simd/issues/210
22-
all(target_arch = "mips", target_endian = "big"),
23-
all(target_arch = "mips64", target_endian = "big"),
24-
target_arch = "sparc64",
25-
target_arch = "s390x",
26-
)))]
22+
target_endian = "big"
23+
))]
2724
pub mod [<$id _bitmask>] {
2825
use super::*;
2926
#[cfg_attr(not(target_arch = "wasm32"), test)]

0 commit comments

Comments
 (0)