Skip to content

Conversation

@RalfJung
Copy link
Member

Another day, another AllocRef API change.

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Aug 27, 2020

📌 Commit 39e6bae has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Aug 27, 2020

⌛ Testing commit 39e6bae with merge 13ea745...

@TimDiekmann
Copy link
Member

I don't expect another change to AllocRef anytime soon (if any). However, as only System and Global are tested, miri could also use GlobalAlloc instead.

@bors
Copy link
Contributor

bors commented Aug 27, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 13ea745 to master...

@bors bors merged commit 13ea745 into rust-lang:master Aug 27, 2020
@RalfJung
Copy link
Member Author

It's okay, I am happy the API is being designed with as much care as it is instead of just releasing "whatever works". :)

Part of the point here was to specifically also test the glue code in liballoc that implements AllocRef on top of GlobalAlloc.

@RalfJung RalfJung deleted the rustup branch August 27, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants