Skip to content

Miri test checks std::fmt implementation details #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m-ou-se opened this issue Apr 24, 2023 · 0 comments · Fixed by #2854
Closed

Miri test checks std::fmt implementation details #2853

m-ou-se opened this issue Apr 24, 2023 · 0 comments · Fixed by #2854

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Apr 24, 2023

Hi!

The fail/panic/double_panic test stderr file contains a backtrace with many internal functions of std's panic and formatting code.

This means this test breaks every time I refactor something there. For example here and here.

I'm not exactly sure what the test is testing, but if it's not too much effort, it'd be nice if the test could be restricted to only test whatever it needed to test for miri, such that it doesn't fail if we change something in std::panicking or std::fmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant