use meta data in crox events to be able to merge multiple logs #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andjo403
force-pushed
the
multi_process_support
branch
2 times, most recently
from
e56a770 to
6d3a912
Compare
deserialize metadata and store it in ProfilingData. use the start_time as base for all event times. to be able to use merge multiple crox logs: use the porcess_id for the crox events. use duration from epoch as timestamp in the crox events.
if dir is added all events files will be located in that dir and then all event will be merged to one chrome_profiler.json file
andjo403
force-pushed
the
multi_process_support
branch
from
6d3a912 to
bd7018e
Compare
wesleywiser
approved these changes
Nov 12, 2019
Member
wesleywiser
left a comment
wesleywiser
left a comment
There was a problem hiding this comment.
Overall this looks awesome! 🎉
Member
|
Some screenshots from doing
|
Contributor
Author
|
fixed the comment |
wesleywiser
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add parameter
--dirthat merges all events in the directory to one chrome_profiler.json file.makes it possible to give multiple file_prefixes and will merge all of them to one chrome_profiler.json file.
also use the crate name from the cmd metadata to show what process_id is from what crate build.