Skip to content

Commit 9073eb4

Browse files
committed
Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
when the binary loaded in memory has a section that we cannot find in the on-disk version. I added this warning out of an overabundance of caution originally, but I've never seen an instance of it being hit in the past few years, and there are some changes for the shared cache on darwin systems where a segment is added when the shared cache is constructed so we're now hitting this warning. I've decided to remove it altogether. <rdar://problem/46889346> llvm-svn: 352158
1 parent 1b1e685 commit 9073eb4

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,15 +255,7 @@ bool DynamicLoaderDarwin::UpdateImageLoadAddress(Module *module,
255255

256256
changed = m_process->GetTarget().SetSectionLoadAddress(
257257
section_sp, new_section_load_addr, warn_multiple);
258-
} else {
259-
Host::SystemLog(
260-
Host::eSystemLogWarning,
261-
"warning: unable to find and load segment named '%s' at "
262-
"0x%" PRIx64 " in '%s' in macosx dynamic loader plug-in.\n",
263-
info.segments[i].name.AsCString("<invalid>"),
264-
(uint64_t)new_section_load_addr,
265-
image_object_file->GetFileSpec().GetPath().c_str());
266-
}
258+
}
267259
}
268260
}
269261

0 commit comments

Comments
 (0)