Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit e8173e8

Browse files
committed
Change sqrt to use wrapping operations
1 parent 8e857c7 commit e8173e8

File tree

1 file changed

+32
-31
lines changed

1 file changed

+32
-31
lines changed

src/math/sqrt.rs

+32-31
Original file line numberDiff line numberDiff line change
@@ -77,35 +77,36 @@
7777
*/
7878

7979
use core::f64;
80+
use core::num::Wrapping;
8081

8182
const TINY: f64 = 1.0e-300;
8283

8384
#[inline]
8485
pub fn sqrt(x: f64) -> f64 {
8586
let mut z: f64;
86-
let sign: u32 = 0x80000000;
87+
let sign: Wrapping<u32> = Wrapping(0x80000000);
8788
let mut ix0: i32;
8889
let mut s0: i32;
8990
let mut q: i32;
9091
let mut m: i32;
9192
let mut t: i32;
9293
let mut i: i32;
93-
let mut r: u32;
94-
let mut t1: u32;
95-
let mut s1: u32;
96-
let mut ix1: u32;
97-
let mut q1: u32;
94+
let mut r: Wrapping<u32>;
95+
let mut t1: Wrapping<u32>;
96+
let mut s1: Wrapping<u32>;
97+
let mut ix1: Wrapping<u32>;
98+
let mut q1: Wrapping<u32>;
9899

99100
ix0 = (x.to_bits() >> 32) as i32;
100-
ix1 = x.to_bits() as u32;
101+
ix1 = Wrapping(x.to_bits() as u32);
101102

102103
/* take care of Inf and NaN */
103104
if (ix0 & 0x7ff00000) == 0x7ff00000 {
104105
return x * x + x; /* sqrt(NaN)=NaN, sqrt(+inf)=+inf, sqrt(-inf)=sNaN */
105106
}
106107
/* take care of zero */
107108
if ix0 <= 0 {
108-
if ((ix0 & !(sign as i32)) | ix1 as i32) == 0 {
109+
if ((ix0 & !(sign.0 as i32)) | ix1.0 as i32) == 0 {
109110
return x; /* sqrt(+-0) = +-0 */
110111
}
111112
if ix0 < 0 {
@@ -118,7 +119,7 @@ pub fn sqrt(x: f64) -> f64 {
118119
/* subnormal x */
119120
while ix0 == 0 {
120121
m -= 21;
121-
ix0 |= (ix1 >> 11) as i32;
122+
ix0 |= (ix1 >> 11).0 as i32;
122123
ix1 <<= 21;
123124
}
124125
i = 0;
@@ -127,46 +128,46 @@ pub fn sqrt(x: f64) -> f64 {
127128
ix0 <<= 1;
128129
}
129130
m -= i - 1;
130-
ix0 |= (ix1 >> (32 - i)) as i32;
131-
ix1 <<= i;
131+
ix0 |= (ix1 >> (32 - i) as usize).0 as i32;
132+
ix1 = ix1 << i as usize;
132133
}
133134
m -= 1023; /* unbias exponent */
134135
ix0 = (ix0 & 0x000fffff) | 0x00100000;
135136
if (m & 1) == 1 {
136137
/* odd m, double x to make it even */
137-
ix0 += ix0 + ((ix1 & sign) >> 31) as i32;
138+
ix0 += ix0 + ((ix1 & sign) >> 31).0 as i32;
138139
ix1 += ix1;
139140
}
140141
m >>= 1; /* m = [m/2] */
141142

142143
/* generate sqrt(x) bit by bit */
143-
ix0 += ix0 + ((ix1 & sign) >> 31) as i32;
144+
ix0 += ix0 + ((ix1 & sign) >> 31).0 as i32;
144145
ix1 += ix1;
145146
q = 0; /* [q,q1] = sqrt(x) */
146-
q1 = 0;
147+
q1 = Wrapping(0);
147148
s0 = 0;
148-
s1 = 0;
149-
r = 0x00200000; /* r = moving bit from right to left */
149+
s1 = Wrapping(0);
150+
r = Wrapping(0x00200000); /* r = moving bit from right to left */
150151

151-
while r != 0 {
152-
t = s0 + r as i32;
152+
while r != Wrapping(0) {
153+
t = s0 + r.0 as i32;
153154
if t <= ix0 {
154-
s0 = t + r as i32;
155+
s0 = t + r.0 as i32;
155156
ix0 -= t;
156-
q += r as i32;
157+
q += r.0 as i32;
157158
}
158-
ix0 += ix0 + ((ix1 & sign) >> 31) as i32;
159+
ix0 += ix0 + ((ix1 & sign) >> 31).0 as i32;
159160
ix1 += ix1;
160161
r >>= 1;
161162
}
162163

163164
r = sign;
164-
while r != 0 {
165+
while r != Wrapping(0) {
165166
t1 = s1 + r;
166167
t = s0;
167168
if t < ix0 || (t == ix0 && t1 <= ix1) {
168169
s1 = t1 + r;
169-
if (t1 & sign) == sign && (s1 & sign) == 0 {
170+
if (t1 & sign) == sign && (s1 & sign) == Wrapping(0) {
170171
s0 += 1;
171172
}
172173
ix0 -= t;
@@ -176,26 +177,26 @@ pub fn sqrt(x: f64) -> f64 {
176177
ix1 -= t1;
177178
q1 += r;
178179
}
179-
ix0 += ix0 + ((ix1 & sign) >> 31) as i32;
180+
ix0 += ix0 + ((ix1 & sign) >> 31).0 as i32;
180181
ix1 += ix1;
181182
r >>= 1;
182183
}
183184

184185
/* use floating add to find out rounding direction */
185-
if (ix0 as u32 | ix1) != 0 {
186+
if (ix0 as u32 | ix1.0) != 0 {
186187
z = 1.0 - TINY; /* raise inexact flag */
187188
if z >= 1.0 {
188189
z = 1.0 + TINY;
189-
if q1 == 0xffffffff {
190-
q1 = 0;
190+
if q1.0 == 0xffffffff {
191+
q1 = Wrapping(0);
191192
q += 1;
192193
} else if z > 1.0 {
193-
if q1 == 0xfffffffe {
194+
if q1.0 == 0xfffffffe {
194195
q += 1;
195196
}
196-
q1 += 2;
197+
q1 += Wrapping(2);
197198
} else {
198-
q1 += q1 & 1;
199+
q1 += q1 & Wrapping(1);
199200
}
200201
}
201202
}
@@ -205,5 +206,5 @@ pub fn sqrt(x: f64) -> f64 {
205206
ix1 |= sign;
206207
}
207208
ix0 += m << 20;
208-
f64::from_bits((ix0 as u64) << 32 | ix1 as u64)
209+
f64::from_bits((ix0 as u64) << 32 | ix1.0 as u64)
209210
}

0 commit comments

Comments
 (0)