Update libc version to 0.2.140 to support s390x #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Mar 30, 2023
gccjit_sys/Cargo.toml
Outdated
| @@ -12,4 +12,4 @@ repository = "https://github.com/swgillespie/gccjit.rs" | |||
| master = [] | |||
|
|
|||
| [dependencies] | |||
| libc = "0.1.6" | |||
| libc = "0.2.140" | |||
There was a problem hiding this comment.
I'm not too familiar with semver, but I believe it would be more flexible to do the following:
Suggested change
| libc = "0.2.140" | |
| libc = "0.2" |
and use the version with s390x support in the project using this library, by having version 0.2.140 in the Cargo.lock of rustc_codegen_gcc, for instance.
There was a problem hiding this comment.
It doesn't actually have to be 0.2.140 specifically, s390x has been supported since 2016 or so, but not yet quite in 2015.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses rust-lang/rust#109774.
I've simply chosen the current latest libc version - let me know if you prefer anything else.