Fix clippy lints

Author: GuillaumeGomez

crates/metadata/lib.rs

@@ -71,6 +71,7 @@ pub const DEFAULT_TARGETS: &[&str] = &[
 #[non_exhaustive]
 pub enum MetadataError {
     /// The error returned when the manifest could not be read.
+    #[allow(clippy::upper_case_acronyms)]
     #[error("failed to read manifest from disk")]
     IO(#[from] io::Error),
     /// The error returned when the manifest could not be parsed.

src/repositories/github.rs

@@ -145,19 +145,17 @@ impl RepositoryForge for GitHub {
         // When a node is missing (for example if the repository was deleted or made private) the
         // GraphQL API will return *both* a `null` instead of the data in the nodes list and a
         // `NOT_FOUND` error in the errors list.
-        for node in response.data.nodes.into_iter() {
-            if let Some(node) = node {
-                let repo = Repository {
-                    id: node.id,
-                    name_with_owner: node.name_with_owner,
-                    description: node.description,
-                    last_activity_at: node.pushed_at,
-                    stars: node.stargazer_count,
-                    forks: node.fork_count,
-                    issues: node.issues.total_count,
-                };
-                ret.present.insert(repo.id.clone(), repo);
-            }
+        for node in response.data.nodes.into_iter().flatten() {
+            let repo = Repository {
+                id: node.id,
+                name_with_owner: node.name_with_owner,
+                description: node.description,
+                last_activity_at: node.pushed_at,
+                stars: node.stargazer_count,
+                forks: node.fork_count,
+                issues: node.issues.total_count,
+            };
+            ret.present.insert(repo.id.clone(), repo);
         }
 
         Ok(ret)

src/repositories/gitlab.rs

@@ -128,21 +128,19 @@ impl RepositoryForge for GitLab {
             if !response.errors.is_empty() {
                 failure::bail!("error updating repositories: {:?}", response.errors);
             }
-            for node in data.projects.nodes.into_iter() {
-                if let Some(node) = node {
-                    let repo = Repository {
-                        id: node.id,
-                        name_with_owner: node.full_path,
-                        description: node.description,
-                        last_activity_at: node.last_activity_at,
-                        stars: node.star_count,
-                        forks: node.forks_count,
-                        issues: node.open_issues_count.unwrap_or(0),
-                    };
-                    let id = repo.id.clone();
-                    node_ids.remove(&id);
-                    ret.present.insert(id, repo);
-                }
+            for node in data.projects.nodes.into_iter().flatten() {
+                let repo = Repository {
+                    id: node.id,
+                    name_with_owner: node.full_path,
+                    description: node.description,
+                    last_activity_at: node.last_activity_at,
+                    stars: node.star_count,
+                    forks: node.forks_count,
+                    issues: node.open_issues_count.unwrap_or(0),
+                };
+                let id = repo.id.clone();
+                node_ids.remove(&id);
+                ret.present.insert(id, repo);
             }
 
             if ret.present.is_empty() && rate_limit.map(|x| x < 1).unwrap_or(false) {

src/web/crate_details.rs

@@ -134,17 +134,16 @@ impl CrateDetails {
         // get releases, sorted by semver
         let releases = releases_for_crate(conn, crate_id);
 
-        let repository_metadata = if let Some(host) = krate.get::<_, Option<String>>("repo_host") {
-            Some(RepositoryMetadata {
-                issues: krate.get("repo_issues"),
-                stars: krate.get("repo_stars"),
-                forks: krate.get("repo_forks"),
-                name: krate.get("repo_name"),
-                icon: up.get_icon_name(&host),
-            })
-        } else {
-            None
-        };
+        let repository_metadata =
+            krate
+                .get::<_, Option<String>>("repo_host")
+                .map(|host| RepositoryMetadata {
+                    issues: krate.get("repo_issues"),
+                    stars: krate.get("repo_stars"),
+                    forks: krate.get("repo_forks"),
+                    name: krate.get("repo_name"),
+                    icon: up.get_icon_name(&host),
+                });
 
         let metadata = MetaData {
             name: krate.get("name"),