Skip to content

Commit 2df41e1

Browse files
committed
db: show errors happening when deleting a file from S3
1 parent bd90856 commit 2df41e1

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

src/db/delete_crate.rs

+16-9
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,22 @@ fn delete_prefix_from_s3(s3: &S3Client, name: &str) -> Result<(), Error> {
9797
version_id: None,
9898
})
9999
.collect::<Vec<_>>();
100-
s3.delete_objects(DeleteObjectsRequest {
101-
bucket: S3_BUCKET_NAME.into(),
102-
delete: rusoto_s3::Delete {
103-
objects: to_delete,
104-
quiet: None,
105-
},
106-
..DeleteObjectsRequest::default()
107-
})
108-
.sync()?;
100+
let resp = s3
101+
.delete_objects(DeleteObjectsRequest {
102+
bucket: S3_BUCKET_NAME.into(),
103+
delete: rusoto_s3::Delete {
104+
objects: to_delete,
105+
quiet: None,
106+
},
107+
..DeleteObjectsRequest::default()
108+
})
109+
.sync()?;
110+
if let Some(errs) = resp.errors {
111+
for err in &errs {
112+
log::error!("error deleting file from s3: {:?}", err);
113+
}
114+
failure::bail!("uploading to s3 failed");
115+
}
109116

110117
continuation_token = list.continuation_token;
111118
if continuation_token.is_none() {

0 commit comments

Comments
 (0)