Skip to content

Commit 022121e

Browse files
jyn514Joshua Nelson
authored and
Joshua Nelson
committed
Add test for missing dependency kind
1 parent 6b74ba1 commit 022121e

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

src/test/fakes.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ impl<'a> FakeRelease<'a> {
153153
self
154154
}
155155

156+
/// Returns the release_id
156157
pub(crate) fn create(self) -> Result<i32, Error> {
157158
use std::collections::HashSet;
158159
use std::fs;

src/web/rustdoc.rs

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1360,7 +1360,7 @@ mod test {
13601360

13611361
#[test]
13621362
fn test_target_redirect_not_found() {
1363-
crate::test::wrapper(|env| {
1363+
wrapper(|env| {
13641364
let web = env.frontend();
13651365
assert_eq!(
13661366
web.get("/crate/fdsafdsafdsafdsa/0.1.0/target-redirect/x86_64-apple-darwin/")
@@ -1374,7 +1374,7 @@ mod test {
13741374

13751375
#[test]
13761376
fn test_fully_yanked_crate_404s() {
1377-
crate::test::wrapper(|env| {
1377+
wrapper(|env| {
13781378
let db = env.db();
13791379

13801380
db.fake_release()
@@ -1400,7 +1400,7 @@ mod test {
14001400
#[test]
14011401
// regression test for https://github.com/rust-lang/docs.rs/issues/856
14021402
fn test_no_trailing_slash() {
1403-
crate::test::wrapper(|env| {
1403+
wrapper(|env| {
14041404
let db = env.db();
14051405
db.fake_release().name("dummy").version("0.1.0").create()?;
14061406
let web = env.frontend();
@@ -1427,4 +1427,22 @@ mod test {
14271427
Ok(())
14281428
})
14291429
}
1430+
1431+
#[test]
1432+
// regression test for https://github.com/rust-lang/docs.rs/pull/885#issuecomment-655147643
1433+
fn test_no_panic_on_missing_kind() {
1434+
wrapper(|env| {
1435+
let db = env.db();
1436+
let id = db.fake_release().name("strum").version("0.13.0").create()?;
1437+
// https://stackoverflow.com/questions/18209625/how-do-i-modify-fields-inside-the-new-postgresql-json-datatype
1438+
db.conn().query(
1439+
r#"UPDATE releases SET dependencies = dependencies::jsonb #- '{0,2}' WHERE id = $1"#,
1440+
&[&id],
1441+
)?;
1442+
let web = env.frontend();
1443+
assert_success("/strum/0.13.0/strum/", web)?;
1444+
assert_success("/crate/strum/0.13.0/", web)?;
1445+
Ok(())
1446+
})
1447+
}
14301448
}

0 commit comments

Comments
 (0)