-
Notifications
You must be signed in to change notification settings - Fork 649
Login error covers login link #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we've decided to revert the layout change for now until we've decided how we want to approach this issue |
I think this was closed without being resolved (or maybe something changed in the meantime). I still get the following behavior: Covering the login link. My expected behavior isn't about the positioning of the link or the error message. It is that the entire page should be a clear message instructing the user how to log in (or, possibly skip that entire process if they have already authorized). That is, the current experience is:
I would expect it to be:
|
@ehuss yeah, I agree that I was too quick with resolving this. The primary issue reported here I think was caused by #3681, which moved the login link to the far right side of the screen, which increase the chance of intersecting with that notification messages. But I agree that the notification message itself it not a great solution, and I have a rough idea on how to implement a fullsize "you need to authenticate to visit this page" page. |
Describe the bug
When running
cargo login
to log in, it instructs you to visit https://crates.io/me. Doing that, I see the following:with no obvious clue what to do. You have to wait for that error to go away to reveal the login link below it. If you have a small-width display, the login link is further hidden behind a Menu drop-down. Even then, it is not obvious what to do if you don't already know how crates.io authentication works.
To Reproduce
Be logged out. Then visit https://crates.io/me.
Expected behavior
If you are not logged in, visiting https://crates.io/me should display a login page (or some sort of page to indicate you need to do something to proceed). Another alternative is if you are already logged in to GitHub to automatically pass through, though I'm not sure how I feel about that.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: