Skip to content

Login error covers login link #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehuss opened this issue Jun 8, 2021 · 4 comments · Fixed by #3696 or #4315
Closed

Login error covers login link #3687

ehuss opened this issue Jun 8, 2021 · 4 comments · Fixed by #3696 or #4315
Labels
C-bug 🐞 Category: unintended, undesired behavior

Comments

@ehuss
Copy link
Contributor

ehuss commented Jun 8, 2021

Describe the bug
When running cargo login to log in, it instructs you to visit https://crates.io/me. Doing that, I see the following:

image

with no obvious clue what to do. You have to wait for that error to go away to reveal the login link below it. If you have a small-width display, the login link is further hidden behind a Menu drop-down. Even then, it is not obvious what to do if you don't already know how crates.io authentication works.

To Reproduce
Be logged out. Then visit https://crates.io/me.

Expected behavior
If you are not logged in, visiting https://crates.io/me should display a login page (or some sort of page to indicate you need to do something to proceed). Another alternative is if you are already logged in to GitHub to automatically pass through, though I'm not sure how I feel about that.

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Any
@ehuss ehuss added the C-bug 🐞 Category: unintended, undesired behavior label Jun 8, 2021
@wangkirin
Copy link
Contributor

wangkirin commented Jun 9, 2021

I think this issue is caused by the adjustment of header in PR #3681
Maybe we need to adjust the position of notifications in sync.

How about set position from top-right to top like this ? @Turbo87
position-top

@Turbo87
Copy link
Member

Turbo87 commented Jun 11, 2021

we've decided to revert the layout change for now until we've decided how we want to approach this issue

@bors bors closed this as completed in 32e705e Jun 11, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Dec 22, 2021

I think this was closed without being resolved (or maybe something changed in the meantime). I still get the following behavior:

image

Covering the login link.

My expected behavior isn't about the positioning of the link or the error message. It is that the entire page should be a clear message instructing the user how to log in (or, possibly skip that entire process if they have already authorized).

That is, the current experience is:

  1. Go to crates.io/me
  2. see home page with error message
  3. wait for error message to disappear
  4. determine that you need to click the sign in link
  5. popup page to authorize with GitHub
  6. land in settings page.

I would expect it to be:

  1. Go to crates.io/me
  2. page to authorize with GitHub
  3. land in settings page

@Turbo87 Turbo87 reopened this Dec 22, 2021
@Turbo87
Copy link
Member

Turbo87 commented Dec 22, 2021

@ehuss yeah, I agree that I was too quick with resolving this. The primary issue reported here I think was caused by #3681, which moved the login link to the far right side of the screen, which increase the chance of intersecting with that notification messages.

But I agree that the notification message itself it not a great solution, and I have a rough idea on how to implement a fullsize "you need to authenticate to visit this page" page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
3 participants