Skip to content

Versions are sorted alphabetically instead of numerically #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wtfsck opened this issue Feb 6, 2021 · 1 comment · Fixed by #3246
Closed

Versions are sorted alphabetically instead of numerically #3245

wtfsck opened this issue Feb 6, 2021 · 1 comment · Fixed by #3246
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@wtfsck
Copy link

wtfsck commented Feb 6, 2021

Describe the bug

1.10.0 is sorted after 1.9.0

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://crates.io/crates/iced-x86
  2. Scroll down to the download stats
  3. 1.10.0 is sorted after 1.9.0

Expected behavior

1.10.0 should be sorted before 1.9.0
@wtfsck wtfsck added the C-bug 🐞 Category: unintended, undesired behavior label Feb 6, 2021
@Turbo87
Copy link
Member

Turbo87 commented Feb 6, 2021

I suspect that #3234 might be responsible for this unintentional change. I suppose we could use something like https://github.com/npm/node-semver/blob/v7.3.4/functions/sort.js to fix this.

@plaets plaets mentioned this issue Feb 7, 2021
Merged
@bors bors closed this as completed in 182290c Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort versions in download graph using semverSort plaets/crates.io
2 participants
@Turbo87 @wtfsck